Skip to content

check coordinates in regular grid #138 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

check coordinates in regular grid #138 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ Changed
Fixed
^^^^^

- Check strictly increasing coordinates for RegularGridDataset.

Added
^^^^^

Expand Down
4 changes: 4 additions & 0 deletions src/py_eddy_tracker/dataset/grid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,10 @@ def setup_coordinates(self):
raise Exception(
"Coordinates in RegularGridDataset must be 1D array, or think to use UnRegularGridDataset"
)
dx = self.x_bounds[1:] - self.x_bounds[:-1]
dy = self.y_bounds[1:] - self.y_bounds[:-1]
if (dx < 0).any() or (dy < 0).any():
raise Exception("Coordinates in RegularGridDataset must be strictly increasing")
self._x_step = (self.x_c[1:] - self.x_c[:-1]).mean()
self._y_step = (self.y_c[1:] - self.y_c[:-1]).mean()

Expand Down