Update tracker scripts `grep' behaviour #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to manual page and StackOverflow, when there is a match grep returns 'SUCCESS', so the logic of the 'if' code must be inverted. In addition, for better output readability, instead of "failure" the output may be "already added" as `transmission-remote` says "Invalid argument" when a torrent has the specific tracker included
The same behavior described in 04d5da1 applies here
Javinator9889
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to manual page and StackOverflow, when there is a match grep returns '
SUCCESS', so the logic of theifcode must be inverted. In addition, for better output readability, instead of failure the output may be already added astransmission-remotesays "Invalid argument" when a torrent has the specific tracker included