[Feature] Made checking for internet connection optional (alexjustesen#1507)

Author: alexjustesen

app/Jobs/Speedtests/ExecuteOoklaSpeedtest.php

@@ -42,26 +42,7 @@ public function __construct(
      */
     public function handle(): void
     {
-        /**
-         * Check for an internet connection first.
-         */
-        $ping = new Ping(
-            host: config('speedtest.ping_url'),
-            timeout: 3,
-        );
-
-        if ($ping->ping() === false) {
-            $this->result->update([
-                'data' => [
-                    'type' => 'log',
-                    'level' => 'error',
-                    'message' => 'Could not resolve host.',
-                ],
-                'status' => ResultStatus::Failed,
-            ]);
-
-            SpeedtestFailed::dispatch($this->result);
-
+        if (! $this->checkForInternetConnection()) {
             return;
         }
 
@@ -104,4 +85,34 @@ public function handle(): void
 
         SpeedtestCompleted::dispatch($this->result);
     }
+
+    protected function checkForInternetConnection(): bool
+    {
+        // Skip checking for internet connection if ping url isn't set (disabled)
+        if (blank(config('speedtest.ping_url'))) {
+            return true;
+        }
+
+        $ping = new Ping(
+            host: config('speedtest.ping_url'),
+            timeout: 3,
+        );
+
+        if ($ping->ping() === false) {
+            $this->result->update([
+                'data' => [
+                    'type' => 'log',
+                    'level' => 'error',
+                    'message' => 'Could not resolve host.',
+                ],
+                'status' => ResultStatus::Failed,
+            ]);
+
+            SpeedtestFailed::dispatch($this->result);
+
+            return false;
+        }
+
+        return true;
+    }
 }

config/speedtest.php

@@ -29,7 +29,7 @@
     /**
      * Speedtest settings.
      */
-    'ping_url' => env('SPEEDTEST_PING_URL', '1.1.1.1'),
+    'ping_url' => env('SPEEDTEST_PING_URL'),
 
     'schedule' => env('SPEEDTEST_SCHEDULE'),