number_format returns a string (alexjustesen#256)

alexjustesen · web-flow · commit 9c2fe6ac7571 · 2022-12-21T14:44:28.000-05:00
diff --git a/app/Providers/FilamentServiceProvider.php b/app/Providers/FilamentServiceProvider.php
@@ -32,7 +32,7 @@ public function boot()
             return true;
         });
 
-        FilamentVersions::addItem('Speedtest Tracker', 'v0.9.0');
+        FilamentVersions::addItem('Speedtest Tracker', 'v0.9.1');
 
         Filament::serving(function () {
             Filament::registerNavigationGroups([
diff --git a/app/helpers.php b/app/helpers.php
@@ -46,7 +46,7 @@ function formatBytestoBits(int $bytes)
 }
 
 if (! function_exists('percentChange')) {
-    function percentChange(float $dividend, float $divisor, int $precision = 0): float
+    function percentChange(float $dividend, float $divisor, int $precision = 0): string
     {
         $quotient = ($dividend - $divisor) / $divisor;
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ function formatBytestoBits(int $bytes)`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`if (! function_exists('percentChange')) {`
`49`		`- function percentChange(float $dividend, float $divisor, int $precision = 0): float`
	`49`	`+ function percentChange(float $dividend, float $divisor, int $precision = 0): string`
`50`	`50`	`{`
`51`	`51`	`$quotient = ($dividend - $divisor) / $divisor;`
`52`	`52`