#179. Delete list records from SummaryRecord class.

Author: bogdan-evtushenko

app/src/main/java/com/blogspot/e_kanivets/moneytracker/report/record/RecordReport.java

@@ -190,20 +190,7 @@ private SummaryRecord createSummaryRecord(String title, List<Record> recordList)
             amount += getAmount(record);
         }
 
-        SummaryRecord summaryRecord = new SummaryRecord(title, currency, amount);
-
-        for (Record record : recordList) {
-            summaryRecord.add(record);
-        }
-
-        Collections.sort(summaryRecord.getRecordList(), new Comparator<Record>() {
-            @Override
-            public int compare(Record lhs, Record rhs) {
-                return compareDoubles(getAmount(lhs), getAmount(rhs));
-            }
-        });
-
-        return summaryRecord;
+        return new SummaryRecord(title, currency, amount, recordList.size());
     }
 
     private double getAmount(Record record) {

app/src/main/java/com/blogspot/e_kanivets/moneytracker/report/record/RecordReportConverter.java

@@ -1,3 +1,4 @@
+
 package com.blogspot.e_kanivets.moneytracker.report.record;
 
 import android.support.annotation.LayoutRes;
@@ -18,6 +19,7 @@
  *
  * @author Evgenii Kanivets
  */
+
 public class RecordReportConverter {
     public static final String TITLE_PARAM_NAME = "title";
     public static final String PRICE_PARAM_NAME = "price";
@@ -65,7 +67,7 @@ public List<? extends List<? extends Map<String, String>>> getChildData() {
             List<Map<String, String>> childDataItem = new ArrayList<>();
             for (SummaryRecord summaryRecord : categoryRecord.getSummaryRecordList()) {
                 Map<String, String> m = new HashMap<>();
-                m.put(TITLE_PARAM_NAME, getTitle(summaryRecord));
+                m.put(TITLE_PARAM_NAME, summaryRecord.getTitle());
                 m.put(PRICE_PARAM_NAME, Double.toString(summaryRecord.getAmount()));
 
                 childDataItem.add(m);
@@ -92,9 +94,4 @@ public int[] getChildTo() {
         return new int[]{R.id.tvCategory, R.id.tvTotal};
     }
 
-    private String getTitle(@NonNull SummaryRecord record) {
-        int count = record.getRecordList().size();
-        if (count <= 1) return record.getTitle();
-        else return record.getTitle() + " (" + count + ")";
-    }
-}
+}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/report/record/model/SummaryRecord.java

@@ -2,11 +2,6 @@
 
 import android.support.annotation.NonNull;
 
-import com.blogspot.e_kanivets.moneytracker.entity.data.Record;
-
-import java.util.ArrayList;
-import java.util.List;
-
 /**
  * Entity class.
  * Created on 2/25/16.
@@ -17,17 +12,11 @@ public class SummaryRecord {
     private String title;
     private String currency;
     private double amount;
-    private List<Record> recordList;
 
-    public SummaryRecord(String title, String currency, double amount) {
-        this.title = title;
+    public SummaryRecord(String title, String currency, double amount, int recordsCount) {
+        this.title = makeTitle(title, recordsCount);
         this.currency = currency;
         this.amount = amount;
-        recordList = new ArrayList<>();
-    }
-
-    public void add(@NonNull Record record) {
-        recordList.add(record);
     }
 
     public String getTitle() {
@@ -42,17 +31,9 @@ public double getAmount() {
         return amount;
     }
 
-    public List<Record> getRecordList() {
-        return recordList;
+    private String makeTitle(String title, int recordsCount) {
+        if (recordsCount <= 1) return title;
+        else return title + " (" + recordsCount + ")";
     }
 
-    @Override
-    public boolean equals(Object o) {
-        if (o instanceof SummaryRecord) {
-            SummaryRecord summaryRecord = (SummaryRecord) o;
-            return this.currency.equals(summaryRecord.getCurrency())
-                    && this.amount == summaryRecord.getAmount()
-                    && this.recordList.equals(summaryRecord.getRecordList());
-        } else return false;
-    }
 }