#168. Fix bug connected to shortSummary update in first launch.

Author: bogdan-evtushenko

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/account/edit/fragment/AccountOperationsFragment.kt

@@ -5,7 +5,6 @@ import android.view.View
 import com.blogspot.e_kanivets.moneytracker.R
 import com.blogspot.e_kanivets.moneytracker.activity.base.BaseFragment
 import com.blogspot.e_kanivets.moneytracker.adapter.RecordAdapter
-import com.blogspot.e_kanivets.moneytracker.controller.FormatController
 import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController
 import com.blogspot.e_kanivets.moneytracker.controller.data.RecordController
 import com.blogspot.e_kanivets.moneytracker.controller.data.TransferController
@@ -35,7 +34,7 @@ class AccountOperationsFragment : BaseFragment() {
     }
 
     override fun initViews(view: View) {
-        recyclerView.adapter = RecordAdapter(requireContext(), getRecords(), false)
+        recyclerView.adapter = RecordAdapter(requireContext(), getRecords(), false, null)
     }
 
     private fun getRecords(): List<Record> {

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/record/MainActivity.kt

@@ -70,9 +70,7 @@ class MainActivity : BaseDrawerActivity() {
         tvDefaultAccountSum = navigationView.getHeaderView(0).findViewById(R.id.tvDefaultAccountSum)
         tvCurrency = navigationView.getHeaderView(0).findViewById(R.id.tvCurrency)
 
-        recordAdapter = RecordAdapter(this, listOf(), true)
-
-        recordAdapter.setOnItemClickListener { position ->
+        recordAdapter = RecordAdapter(this, listOf(), true) { position ->
             if (position == 0) showReport()
             else editRecord(position)
         }

app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt

@@ -35,9 +35,9 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
     private var summaryPresenter: ShortSummaryPresenter
     private var isHeaderViewNeeded: Boolean = false
-    private lateinit var headerViewHolder: HeaderViewHolder
+    private var headerViewHolder: HeaderViewHolder
 
-    constructor(context: Context, records: List<Record>, isHeaderViewNeeded: Boolean) {
+    constructor(context: Context, records: List<Record>, isHeaderViewNeeded: Boolean, itemClickListener: ((Int) -> Unit)?) {
         this.context = context
         this.records = records
 
@@ -50,7 +50,11 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {
 
         summaryPresenter = ShortSummaryPresenter(context)
 
+        this.itemClickListener = itemClickListener
         this.isHeaderViewNeeded = isHeaderViewNeeded
+
+        headerViewHolder = HeaderViewHolder(LayoutInflater.from(context).inflate(R.layout.view_summary_records, null), itemClickListener)
+        summaryPresenter.create(true, headerViewHolder)
     }
 
     override fun getItemCount() = records.size + if (isHeaderViewNeeded) 1 else 0
@@ -92,19 +96,11 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {
     }
 
     fun setRecords(recordsList: List<Record>, report: IRecordReport?, currency: String, ratesNeeded: List<String>) {
-        if (isHeaderViewNeeded && records.isEmpty()) {
-            headerViewHolder = HeaderViewHolder(LayoutInflater.from(context).inflate(R.layout.view_summary_records, null), itemClickListener)
-            summaryPresenter.create(true, headerViewHolder)
-        }
         records = recordsList
         summaryPresenter.update(report, currency, ratesNeeded)
         notifyDataSetChanged()
     }
 
-    fun setOnItemClickListener(itemClickListener: (Int) -> Unit) {
-        this.itemClickListener = itemClickListener
-    }
-
     class ViewHolder : RecyclerView.ViewHolder {
 
         var container: LinearLayout