#178. Add review fixes.

Author: bogdan-evtushenko

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/ReportActivity.kt

@@ -26,14 +26,12 @@ class ReportActivity : BaseBackActivity() {
     @Inject
     lateinit var currencyController: CurrencyController
 
-    private lateinit var recordList: List<Record>
+    private var recordList: List<Record> = listOf()
     private var period: Period? = null
 
-    private lateinit var shortSummaryPresenter: ShortSummaryPresenter
+    private val shortSummaryPresenter: ShortSummaryPresenter = ShortSummaryPresenter(this)
 
-    override fun getContentViewId(): Int {
-        return R.layout.activity_report
-    }
+    override fun getContentViewId() = R.layout.activity_report
 
     override fun initData(): Boolean {
         super.initData()
@@ -52,7 +50,6 @@ class ReportActivity : BaseBackActivity() {
 
         initSpinnerCurrency()
 
-        shortSummaryPresenter = ShortSummaryPresenter(this)
         expListView.addHeaderView(shortSummaryPresenter.create(false, null))
     }
 
@@ -74,15 +71,12 @@ class ReportActivity : BaseBackActivity() {
     private fun initSpinnerCurrency() {
         val currencyList = currencyController.readAll()
 
-        spinnerCurrency.adapter = ArrayAdapter(this,
-                R.layout.view_spinner_item, currencyList)
+        spinnerCurrency.adapter = ArrayAdapter(this, R.layout.view_spinner_item, currencyList)
         spinnerCurrency.onItemSelectedListener = object : AdapterView.OnItemSelectedListener {
-            override fun onItemSelected(p0: AdapterView<*>?, p1: View?, p2: Int, p3: Long) {
-                update(spinnerCurrency.selectedItem.toString())
-            }
+            override fun onItemSelected(p0: AdapterView<*>?, p1: View?, p2: Int, p3: Long) =
+                    update(spinnerCurrency.selectedItem.toString())
 
-            override fun onNothingSelected(p0: AdapterView<*>?) {
-            }
+            override fun onNothingSelected(p0: AdapterView<*>?) {}
         }
 
         val currency = currencyController.readDefaultCurrency()

app/src/main/java/com/blogspot/e_kanivets/moneytracker/ui/presenter/ShortSummaryPresenter.java

@@ -46,13 +46,13 @@ public ShortSummaryPresenter(Context context) {
         green = context.getResources().getColor(R.color.green);
     }
 
-    public View create(boolean shortSummary, RecordAdapter.SummaryViewHolder mainViewHolder) {
+    public View create(boolean shortSummary, RecordAdapter.SummaryViewHolder viewHolder) {
         view = layoutInflater.inflate(R.layout.view_summary_records, null);
         view.findViewById(R.id.iv_more).setVisibility(shortSummary ? View.VISIBLE : View.INVISIBLE);
         view.setEnabled(false);
         view.findViewById(R.id.lvSummary).setClickable(false);
         view.findViewById(R.id.cvSummary).setClickable(true);
-        view.setTag(mainViewHolder != null ? mainViewHolder : new ViewHolder(view));
+        view.setTag(viewHolder != null ? viewHolder : new ViewHolder(view));
 
         return view;
     }