Skip to content
This repository was archived by the owner on Jun 27, 2020. It is now read-only.

Commit 4bab073

Browse files
author
Evgenii Kanivets
committed
#132[1h]. Move event logging to separate class.
1 parent 9b26e89 commit 4bab073

File tree

12 files changed

+119
-206
lines changed

12 files changed

+119
-206
lines changed

app/src/main/java/com/blogspot/e_kanivets/moneytracker/MtApp.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
import com.blogspot.e_kanivets.moneytracker.di.module.ControllerModule;
88
import com.blogspot.e_kanivets.moneytracker.di.module.repo.CachedRepoModule;
99

10+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1011
import com.crashlytics.android.Crashlytics;
12+
1113
import io.fabric.sdk.android.Fabric;
1214
import timber.log.Timber;
1315

@@ -29,15 +31,18 @@ public static MtApp get() {
2931
@Override
3032
public void onCreate() {
3133
super.onCreate();
32-
if (!BuildConfig.DEBUG) {
33-
Fabric.with(this, new Crashlytics());
34-
}
3534

3635
mtApp = this;
3736
buildAppComponent();
3837

39-
if (BuildConfig.DEBUG) Timber.plant(new Timber.DebugTree());
40-
else Timber.plant(new ReleaseTree());
38+
if (BuildConfig.DEBUG) {
39+
Timber.plant(new Timber.DebugTree());
40+
AnswersProxy.get().setEnabled(false);
41+
} else {
42+
Timber.plant(new ReleaseTree());
43+
Fabric.with(this, new Crashlytics());
44+
AnswersProxy.get().setEnabled(true);
45+
}
4146
}
4247

4348
public AppComponent getAppComponent() {

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/account/AccountsActivity.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
import com.blogspot.e_kanivets.moneytracker.adapter.AccountAdapter;
1515
import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController;
1616
import com.blogspot.e_kanivets.moneytracker.ui.presenter.AccountsSummaryPresenter;
17-
import com.crashlytics.android.answers.Answers;
18-
import com.crashlytics.android.answers.ContentViewEvent;
17+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1918

2019
import javax.inject.Inject;
2120

@@ -101,22 +100,14 @@ public boolean onContextItemSelected(MenuItem item) {
101100
}
102101

103102
public void makeTransfer() {
104-
// Answers event
105-
Answers.getInstance().logContentView(new ContentViewEvent()
106-
.putContentName("Add Transfer")
107-
.putContentType("Button"));
108-
103+
AnswersProxy.get().logButton("Add Transfer");
109104
startActivityForResult(new Intent(AccountsActivity.this, TransferActivity.class),
110105
REQUEST_TRANSFER);
111106
}
112107

113108
@OnClick(R.id.btn_add_account)
114109
public void addAccount() {
115-
// Answers event
116-
Answers.getInstance().logContentView(new ContentViewEvent()
117-
.putContentName("Add Account")
118-
.putContentType("Button"));
119-
110+
AnswersProxy.get().logButton("Add Account");
120111
Intent intent = new Intent(AccountsActivity.this, AddAccountActivity.class);
121112
startActivityForResult(intent, REQUEST_ADD_ACCOUNT);
122113
}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/account/AddAccountActivity.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111
import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController;
1212
import com.blogspot.e_kanivets.moneytracker.controller.CurrencyController;
1313
import com.blogspot.e_kanivets.moneytracker.entity.data.Account;
14+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1415
import com.blogspot.e_kanivets.moneytracker.util.validator.AccountValidator;
1516
import com.blogspot.e_kanivets.moneytracker.util.validator.IValidator;
16-
import com.crashlytics.android.answers.Answers;
17-
import com.crashlytics.android.answers.ContentViewEvent;
1817

1918
import java.util.ArrayList;
2019

@@ -79,17 +78,9 @@ public boolean onOptionsItemSelected(MenuItem item) {
7978
}
8079

8180
private void tryAddAccount() {
82-
// Answers event
83-
Answers.getInstance().logContentView(new ContentViewEvent()
84-
.putContentName("Done Account")
85-
.putContentType("Button"));
86-
81+
AnswersProxy.get().logButton("Done Account");
8782
if (addAccount()) {
88-
// Answers event
89-
Answers.getInstance().logContentView(new ContentViewEvent()
90-
.putContentName("Done Account")
91-
.putContentType("Event"));
92-
83+
AnswersProxy.get().logEvent("Done Account");
9384
setResult(RESULT_OK);
9485
finish();
9586
}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/account/TransferActivity.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@
1212
import com.blogspot.e_kanivets.moneytracker.controller.data.TransferController;
1313
import com.blogspot.e_kanivets.moneytracker.entity.data.Account;
1414
import com.blogspot.e_kanivets.moneytracker.entity.data.Transfer;
15+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1516
import com.blogspot.e_kanivets.moneytracker.util.validator.IValidator;
1617
import com.blogspot.e_kanivets.moneytracker.util.validator.TransferValidator;
17-
import com.crashlytics.android.answers.Answers;
18-
import com.crashlytics.android.answers.ContentViewEvent;
1918

2019
import java.util.ArrayList;
2120
import java.util.List;
@@ -100,17 +99,9 @@ public boolean onOptionsItemSelected(MenuItem item) {
10099
}
101100

102101
private void tryTransfer() {
103-
// Answers event
104-
Answers.getInstance().logContentView(new ContentViewEvent()
105-
.putContentName("Done Transfer")
106-
.putContentType("Button"));
107-
102+
AnswersProxy.get().logButton("Done Transfer");
108103
if (doTransfer()) {
109-
// Answers event
110-
Answers.getInstance().logContentView(new ContentViewEvent()
111-
.putContentName("Done Transfer")
112-
.putContentType("Event"));
113-
104+
AnswersProxy.get().logEvent("Done Transfer");
114105
setResult(RESULT_OK);
115106
finish();
116107
}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/base/BaseDrawerActivity.java

Lines changed: 9 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.blogspot.e_kanivets.moneytracker.activity.base;
22

33
import android.content.Intent;
4+
import android.support.annotation.NonNull;
45
import android.support.design.widget.NavigationView;
56
import android.support.v4.view.GravityCompat;
67
import android.support.v4.widget.DrawerLayout;
@@ -15,8 +16,7 @@
1516
import com.blogspot.e_kanivets.moneytracker.activity.SettingsActivity;
1617
import com.blogspot.e_kanivets.moneytracker.activity.account.AccountsActivity;
1718
import com.blogspot.e_kanivets.moneytracker.activity.exchange_rate.ExchangeRatesActivity;
18-
import com.crashlytics.android.answers.Answers;
19-
import com.crashlytics.android.answers.ContentViewEvent;
19+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
2020

2121
import butterknife.Bind;
2222

@@ -71,7 +71,7 @@ protected void initViews() {
7171
}
7272

7373
@Override
74-
public boolean onNavigationItemSelected(MenuItem item) {
74+
public boolean onNavigationItemSelected(@NonNull MenuItem item) {
7575
switch (item.getItemId()) {
7676
case R.id.nav_accounts:
7777
showAccounts();
@@ -134,60 +134,36 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
134134
}
135135

136136
private void showAccounts() {
137-
// Answers event
138-
Answers.getInstance().logContentView(new ContentViewEvent()
139-
.putContentName("Show Accounts")
140-
.putContentType("Button"));
141-
137+
AnswersProxy.get().logButton("Show Accounts");
142138
startActivityForResult(new Intent(BaseDrawerActivity.this, AccountsActivity.class),
143139
REQUEST_ACCOUNTS);
144140
}
145141

146142
private void showRates() {
147-
// Answers event
148-
Answers.getInstance().logContentView(new ContentViewEvent()
149-
.putContentName("Show Rates")
150-
.putContentType("Button"));
151-
143+
AnswersProxy.get().logButton("Show Rates");
152144
startActivityForResult(new Intent(BaseDrawerActivity.this, ExchangeRatesActivity.class),
153145
REQUEST_RATES);
154146
}
155147

156148
private void showCharts() {
157-
// Answers event
158-
Answers.getInstance().logContentView(new ContentViewEvent()
159-
.putContentName("Show Charts")
160-
.putContentType("Button"));
161-
149+
AnswersProxy.get().logButton("Show Charts");
162150
startActivity(new Intent(BaseDrawerActivity.this, ChartsActivity.class));
163151
}
164152

165153
private void showBackup() {
166-
// Answers event
167-
Answers.getInstance().logContentView(new ContentViewEvent()
168-
.putContentName("Show Backup")
169-
.putContentType("Button"));
170-
154+
AnswersProxy.get().logButton("Show Backup");
171155
startActivityForResult(new Intent(BaseDrawerActivity.this, BackupActivity.class),
172156
REQUEST_BACKUP);
173157
}
174158

175159
private void showImportExport() {
176-
// Answers event
177-
Answers.getInstance().logContentView(new ContentViewEvent()
178-
.putContentName("Show Import Export")
179-
.putContentType("Button"));
180-
160+
AnswersProxy.get().logButton("Show Import Export");
181161
startActivityForResult(new Intent(BaseDrawerActivity.this, ImportExportActivity.class),
182162
REQUEST_IMPORT_EXPORT);
183163
}
184164

185165
private void showSettings() {
186-
// Answers event
187-
Answers.getInstance().logContentView(new ContentViewEvent()
188-
.putContentName("Show Settings")
189-
.putContentType("Button"));
190-
166+
AnswersProxy.get().logButton("Show Settings");
191167
startActivityForResult(new Intent(BaseDrawerActivity.this, SettingsActivity.class),
192168
REQUEST_SETTINGS);
193169
}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/exchange_rate/AddExchangeRateActivity.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@
1414
import com.blogspot.e_kanivets.moneytracker.controller.FormatController;
1515
import com.blogspot.e_kanivets.moneytracker.controller.data.ExchangeRateController;
1616
import com.blogspot.e_kanivets.moneytracker.entity.ExchangeRatePair;
17+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1718
import com.blogspot.e_kanivets.moneytracker.util.validator.ExchangeRatePairValidator;
1819
import com.blogspot.e_kanivets.moneytracker.util.validator.IValidator;
19-
import com.crashlytics.android.answers.Answers;
20-
import com.crashlytics.android.answers.ContentViewEvent;
2120

2221
import java.util.ArrayList;
2322
import java.util.List;
@@ -127,17 +126,9 @@ public boolean onOptionsItemSelected(MenuItem item) {
127126
}
128127

129128
private void tryAddExchangeRate() {
130-
// Answers event
131-
Answers.getInstance().logContentView(new ContentViewEvent()
132-
.putContentName("Done Exchange Rate")
133-
.putContentType("Button"));
134-
129+
AnswersProxy.get().logButton("Done Exchange Rate");
135130
if (addExchangeRate()) {
136-
// Answers event
137-
Answers.getInstance().logContentView(new ContentViewEvent()
138-
.putContentName("Done Exchange Rate")
139-
.putContentType("Event"));
140-
131+
AnswersProxy.get().logEvent("Done Exchange Rate");
141132
setResult(RESULT_OK);
142133
finish();
143134
}

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/exchange_rate/ExchangeRatesActivity.java

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414
import com.blogspot.e_kanivets.moneytracker.adapter.ExchangeRateAdapter;
1515
import com.blogspot.e_kanivets.moneytracker.controller.data.ExchangeRateController;
1616
import com.blogspot.e_kanivets.moneytracker.entity.ExchangeRatePair;
17+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1718
import com.blogspot.e_kanivets.moneytracker.util.ExchangeRatesSummarizer;
18-
import com.crashlytics.android.answers.Answers;
19-
import com.crashlytics.android.answers.ContentViewEvent;
2019

2120
import java.util.Collections;
2221
import java.util.List;
@@ -81,34 +80,22 @@ public boolean onContextItemSelected(MenuItem item) {
8180
}
8281

8382
public void deleteExchangeRate(int position) {
84-
// Answers event
85-
Answers.getInstance().logContentView(new ContentViewEvent()
86-
.putContentName("Delete Exchange Rate")
87-
.putContentType("Button"));
88-
83+
AnswersProxy.get().logButton("Delete Exchange Rate");
8984
rateController.deleteExchangeRatePair(exchangeRateList.get(position));
9085
update();
9186
setResult(RESULT_OK);
9287
}
9388

9489
@OnClick(R.id.btn_add_exchange_rate)
9590
public void addExchangeRate() {
96-
// Answers event
97-
Answers.getInstance().logContentView(new ContentViewEvent()
98-
.putContentName("Add Exchange Rate")
99-
.putContentType("Button"));
100-
91+
AnswersProxy.get().logButton("Add Exchange Rate");
10192
Intent intent = new Intent(ExchangeRatesActivity.this, AddExchangeRateActivity.class);
10293
startActivityForResult(intent, REQUEST_ADD_EXCHANGE_RATE);
10394
}
10495

10596
@OnItemClick(R.id.list_view)
10697
public void addExchangeRateOnBaseOfExisted(int position) {
107-
// Answers event
108-
Answers.getInstance().logContentView(new ContentViewEvent()
109-
.putContentName("Edit Exchange Rate")
110-
.putContentType("Button"));
111-
98+
AnswersProxy.get().logButton("Edit Exchange Rate");
11299
if (position < 0 || position >= exchangeRateList.size()) return;
113100
Intent intent = new Intent(ExchangeRatesActivity.this, AddExchangeRateActivity.class);
114101
intent.putExtra(AddExchangeRateActivity.KEY_EXCHANGE_RATE, exchangeRateList.get(position));

app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/external/BackupActivity.java

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
import com.blogspot.e_kanivets.moneytracker.activity.base.BaseBackActivity;
1313
import com.blogspot.e_kanivets.moneytracker.controller.BackupController;
1414
import com.blogspot.e_kanivets.moneytracker.controller.PreferenceController;
15-
import com.crashlytics.android.answers.Answers;
16-
import com.crashlytics.android.answers.ContentViewEvent;
15+
import com.blogspot.e_kanivets.moneytracker.util.AnswersProxy;
1716
import com.dropbox.client2.DropboxAPI;
1817
import com.dropbox.client2.android.AndroidAuthSession;
1918
import com.dropbox.client2.session.AppKeyPair;
@@ -91,20 +90,12 @@ protected void onResume() {
9190

9291
@OnClick(R.id.btn_backup_now)
9392
public void backupNow() {
94-
// Answers event
95-
Answers.getInstance().logContentView(new ContentViewEvent()
96-
.putContentName("Make Backup")
97-
.putContentType("Button"));
98-
93+
AnswersProxy.get().logButton("Make Backup");
9994
startProgress(getString(R.string.making_backup));
10095
backupController.makeBackup(dbApi, new BackupController.OnBackupListener() {
10196
@Override
10297
public void onBackupSuccess() {
103-
// Answers event
104-
Answers.getInstance().logContentView(new ContentViewEvent()
105-
.putContentName("Backup success")
106-
.putContentType("Event"));
107-
98+
AnswersProxy.get().logEvent("Backup success");
10899
Timber.d("Backup success.");
109100
if (isFinishing()) return;
110101

@@ -114,11 +105,7 @@ public void onBackupSuccess() {
114105

115106
@Override
116107
public void onBackupFailure(String reason) {
117-
// Answers event
118-
Answers.getInstance().logContentView(new ContentViewEvent()
119-
.putContentName("Backup failure")
120-
.putContentType("Event"));
121-
108+
AnswersProxy.get().logEvent("Backup failure");
122109
Timber.d("Backup failure.");
123110
if (isFinishing()) return;
124111

@@ -132,11 +119,7 @@ public void onBackupFailure(String reason) {
132119

133120
@OnItemClick(R.id.list_view)
134121
public void restoreBackupClicked(int position) {
135-
// Answers event
136-
Answers.getInstance().logContentView(new ContentViewEvent()
137-
.putContentName("Restore backup")
138-
.putContentType("Button"));
139-
122+
AnswersProxy.get().logButton("Restore backup");
140123
final String backupName = listView.getAdapter().getItem(position).toString();
141124

142125
AlertDialog.Builder builder = new AlertDialog.Builder(BackupActivity.this);
@@ -157,11 +140,7 @@ private void restoreBackup(final String backupName) {
157140
backupController.restoreBackup(dbApi, backupName, new BackupController.OnRestoreBackupListener() {
158141
@Override
159142
public void onRestoreSuccess() {
160-
// Answers event
161-
Answers.getInstance().logContentView(new ContentViewEvent()
162-
.putContentName("Restore Success")
163-
.putContentType("Event"));
164-
143+
AnswersProxy.get().logEvent("Restore Success");
165144
Timber.d("Restore success.");
166145
if (isFinishing()) return;
167146

@@ -184,11 +163,7 @@ public void onDismiss(DialogInterface dialog) {
184163

185164
@Override
186165
public void onRestoreFailure(String reason) {
187-
// Answers event
188-
Answers.getInstance().logContentView(new ContentViewEvent()
189-
.putContentName("Restore Failure")
190-
.putContentType("Event"));
191-
166+
AnswersProxy.get().logEvent("Restore Failure");
192167
Timber.d("Restore failure.");
193168
if (isFinishing()) return;
194169

0 commit comments

Comments
 (0)