Use clone to deepcopy socks opts

Author: yciabaud

lib/client/http-tracker.js

@@ -2,6 +2,7 @@ module.exports = HTTPTracker
 
 var bencode = require('bencode')
 var compact2string = require('compact2string')
+var clone = require('clone')
 var debug = require('debug')('bittorrent-tracker:http-tracker')
 var extend = require('xtend')
 var get = require('simple-get')
@@ -95,7 +96,7 @@ HTTPTracker.prototype._request = function (requestUrl, params, cb) {
     agent = parsedUrl.protocol === 'https:'
       ? self.client._proxyOpts.httpsAgent : self.client._proxyOpts.httpAgent
     if (!agent && self.client._proxyOpts.socksProxy) {
-      agent = new Socks.Agent(extend(self.client._proxyOpts.socksProxy), (parsedUrl.protocol === 'https:'))
+      agent = new Socks.Agent(clone(self.client._proxyOpts.socksProxy), (parsedUrl.protocol === 'https:'))
     }
   }
   var u = {

lib/client/udp-tracker.js

@@ -2,10 +2,10 @@ module.exports = UDPTracker
 
 var BN = require('bn.js')
 var Buffer = require('safe-buffer').Buffer
+var clone = require('clone')
 var compact2string = require('compact2string')
 var debug = require('debug')('bittorrent-tracker:udp-tracker')
 var dgram = require('dgram')
-var extend = require('xtend')
 var inherits = require('inherits')
 var randombytes = require('randombytes')
 var Socks = require('socks')
@@ -77,7 +77,7 @@ UDPTracker.prototype._request = function (opts) {
   var relay
   var transactionId = genTransactionId()
 
-  var proxyOpts = self.client._proxyOpts && extend(self.client._proxyOpts.socksProxy)
+  var proxyOpts = self.client._proxyOpts && clone(self.client._proxyOpts.socksProxy)
   if (proxyOpts) {
     if (!proxyOpts.proxy) {
       proxyOpts.proxy = {}

lib/client/websocket-tracker.js

@@ -1,5 +1,6 @@
 module.exports = WebSocketTracker
 
+var clone = require('clone')
 var debug = require('debug')('bittorrent-tracker:websocket-tracker')
 var extend = require('xtend')
 var inherits = require('inherits')
@@ -175,7 +176,7 @@ WebSocketTracker.prototype._openSocket = function () {
       agent = parsedUrl.protocol === 'wss:'
         ? self.client._proxyOpts.httpsAgent : self.client._proxyOpts.httpAgent
       if (!agent && self.client._proxyOpts.socksProxy) {
-        agent = new Socks.Agent(extend(self.client._proxyOpts.socksProxy), (parsedUrl.protocol === 'wss:'))
+        agent = new Socks.Agent(clone(self.client._proxyOpts.socksProxy), (parsedUrl.protocol === 'wss:'))
       }
     }
     self.socket = socketPool[self.announceUrl] = new Socket(self.announceUrl, { agent: agent })

package.json

@@ -24,6 +24,7 @@
     "bencode": "^0.10.0",
     "bittorrent-peerid": "^1.0.2",
     "bn.js": "^4.4.0",
+    "clone": "^1.0.2",
     "compact2string": "^1.2.0",
     "debug": "^2.0.0",
     "inherits": "^2.0.1",