Skip to content
This repository was archived by the owner on Aug 30, 2020. It is now read-only.

Commit 1fe3068

Browse files
committed
update readme for the fix in chromedp
1 parent ac1162f commit 1fe3068

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ In the project directory, run
2020
make install-deps build
2121
```
2222

23+
## Important fix in chromedp
24+
25+
In `vendor/github.com/chromedp/chromedp/runner/runner.go:248`, change to `if r.cmd != nil && r.cmd.Process != nil {` as chromium did not shutdown properly and there is no harm sending signalterm anyway.
26+
27+
Comment out `vendor/github.com/chromedp/chromedp/runner/runner.go:11`.
28+
2329
## Setup and Serve
2430

2531
Once you have compiled this project, a binary executable named `pricetracker` should be sitting in your directory. There are some important environment variables that you want to setup before running it.

0 commit comments

Comments
 (0)