ioet#64 Rename actions

Author: jorgecod

src/app/modules/project-management/components/project-list/project-list.component.ts

@@ -23,7 +23,7 @@ export class ProjectListComponent implements OnInit {
   constructor(private store: Store<any>) {}
 
   ngOnInit(): void {
-    this.store.dispatch(new actions.GetProjectsLoad());
+    this.store.dispatch(new actions.LoadProjects());
     const projects$ = this.store.pipe(select(allProjects));
 
     projects$.subscribe((response) => {

src/app/modules/project-management/store/project.actions.spec.ts

@@ -1,14 +1,14 @@
 import * as actions from './project.actions';
 
 describe('Actions for Projects', () => {
-  it('GetProjectsSuccess type is ProjectActionTypes.GET_PROJECTS_SUCCESS', () => {
-    const getProjectsSuccess = new actions.GetProjectsSuccess([]);
-    expect(getProjectsSuccess.type).toEqual(actions.ProjectActionTypes.GET_PROJECTS_SUCCESS);
+  it('LoadProjectsSuccess type is ProjectActionTypes.LOAD_PROJECTS_SUCCESS', () => {
+    const loadProjectsSuccess = new actions.LoadProjectsSuccess([]);
+    expect(loadProjectsSuccess.type).toEqual(actions.ProjectActionTypes.LOAD_PROJECTS_SUCCESS);
   });
 
-  it('getProjectsFail type is ProjectActionTypes.GET_PROJECTS_FAIL', () => {
-    const getProjectsFail = new actions.GetProjectsFail('error');
-    expect(getProjectsFail.type).toEqual(actions.ProjectActionTypes.GET_PROJECTS_FAIL);
+  it('LoadProjectsFail type is ProjectActionTypes.LOAD_PROJECTS_FAIL', () => {
+    const loadProjectsFail = new actions.LoadProjectsFail('error');
+    expect(loadProjectsFail.type).toEqual(actions.ProjectActionTypes.LOAD_PROJECTS_FAIL);
   });
 
   it('CreateProjectSuccess type is ProjectActionTypes.CREATE_PROJECT_SUCCESS', () => {

src/app/modules/project-management/store/project.actions.ts

@@ -2,9 +2,9 @@ import { Action } from '@ngrx/store';
 import { Project } from '../../shared/models';
 
 export enum ProjectActionTypes {
-  GET_PROJECTS = '[Projects] GET_PROJECTS',
-  GET_PROJECTS_SUCCESS = '[Projects] GET_PROJECTS_SUCCESS',
-  GET_PROJECTS_FAIL = '[Projects] GET_PROJECTS_FAIL',
+  LOAD_PROJECTS = '[Projects] LOAD_PROJECTS',
+  LOAD_PROJECTS_SUCCESS = '[Projects] LOAD_PROJECTS_SUCCESS',
+  LOAD_PROJECTS_FAIL = '[Projects] LOAD_PROJECTS_FAIL',
   CREATE_PROJECT = '[Projects] CREATE_PROJECT',
   CREATE_PROJECT_SUCCESS = '[Projects] CREATE_PROJECT_SUCCESS',
   CREATE_PROJECT_FAIL = '[Projects] CREATE_PROJECT_FAIL',
@@ -13,17 +13,17 @@ export enum ProjectActionTypes {
   UPDATE_PROJECT_FAIL = '[Projects] UPDATE_PROJECT_FAIL',
 }
 
-export class GetProjectsLoad implements Action {
-  public readonly type = ProjectActionTypes.GET_PROJECTS;
+export class LoadProjects implements Action {
+  public readonly type = ProjectActionTypes.LOAD_PROJECTS;
 }
 
-export class GetProjectsSuccess implements Action {
-  readonly type = ProjectActionTypes.GET_PROJECTS_SUCCESS;
+export class LoadProjectsSuccess implements Action {
+  readonly type = ProjectActionTypes.LOAD_PROJECTS_SUCCESS;
   constructor(readonly payload: Project[]) {}
 }
 
-export class GetProjectsFail implements Action {
-  public readonly type = ProjectActionTypes.GET_PROJECTS_FAIL;
+export class LoadProjectsFail implements Action {
+  public readonly type = ProjectActionTypes.LOAD_PROJECTS_FAIL;
 
   constructor(public error: string) {}
 }
@@ -65,9 +65,9 @@ export class UpdateProjectFail implements Action {
 }
 
 export type ProjectActions =
-  | GetProjectsLoad
-  | GetProjectsSuccess
-  | GetProjectsFail
+  | LoadProjects
+  | LoadProjectsSuccess
+  | LoadProjectsFail
   | CreateProject
   | CreateProjectSuccess
   | CreateProjectFail

src/app/modules/project-management/store/project.effects.ts

@@ -11,14 +11,14 @@ export class ProjectEffects {
   constructor(private actions$: Actions, private projectService: ProjectService, private store: Store<any>) {}
 
   @Effect()
-  getProjects$: Observable<Action> = this.actions$.pipe(
-    ofType(actions.ProjectActionTypes.GET_PROJECTS),
+  loadProjects$: Observable<Action> = this.actions$.pipe(
+    ofType(actions.ProjectActionTypes.LOAD_PROJECTS),
     mergeMap(() =>
       this.projectService.getProjects().pipe(
         map((project) => {
-          return new actions.GetProjectsSuccess(project);
+          return new actions.LoadProjectsSuccess(project);
         }),
-        catchError((error) => of(new actions.GetProjectsFail(error)))
+        catchError((error) => of(new actions.LoadProjectsFail(error)))
       )
     )
   );

src/app/modules/project-management/store/project.reducer.spec.ts

@@ -5,21 +5,21 @@ import { projectReducer, ProjectState } from './project.reducer';
 describe('projectReducer', () => {
   const initialState: ProjectState = { projectList: [], isLoading: false };
 
-  it('on GetProjects, isLoading is true', () => {
-    const action = new actions.GetProjectsLoad();
+  it('on LoadProjects, isLoading is true', () => {
+    const action = new actions.LoadProjects();
     const state = projectReducer(initialState, action);
     expect(state.isLoading).toEqual(true);
   });
 
-  it('on GetProjectsSuccess, projectsFound are saved in the store', () => {
+  it('on LoadProjectsSuccess, projectsFound are saved in the store', () => {
     const projectsFound: Project[] = [{ id: '', name: '', description: '' }];
-    const action = new actions.GetProjectsSuccess(projectsFound);
+    const action = new actions.LoadProjectsSuccess(projectsFound);
     const state = projectReducer(initialState, action);
     expect(state.projectList).toEqual(projectsFound);
   });
 
-  it('on GetProjectsFail, projectList equal []', () => {
-    const action = new actions.GetProjectsFail('error');
+  it('on LoadProjectsFail, projectList equal []', () => {
+    const action = new actions.LoadProjectsFail('error');
     const state = projectReducer(initialState, action);
     expect(state.projectList).toEqual([]);
   });

src/app/modules/project-management/store/project.reducer.ts

@@ -14,20 +14,20 @@ export const initialState = {
 export const projectReducer = (state: ProjectState = initialState, action: ProjectActions) => {
   const projects = [...state.projectList];
   switch (action.type) {
-    case ProjectActionTypes.GET_PROJECTS: {
+    case ProjectActionTypes.LOAD_PROJECTS: {
       return {
         ...state,
         isLoading: true,
       };
     }
-    case ProjectActionTypes.GET_PROJECTS_SUCCESS:
+    case ProjectActionTypes.LOAD_PROJECTS_SUCCESS:
       return {
         ...state,
         projectList: action.payload,
         isLoading: false,
       };
 
-    case ProjectActionTypes.GET_PROJECTS_FAIL: {
+    case ProjectActionTypes.LOAD_PROJECTS_FAIL: {
       return {
         projectList: [],
         isLoading: false,

src/app/modules/time-clock/components/project-list-hover/project-list-hover.component.ts

@@ -24,7 +24,7 @@ export class ProjectListHoverComponent implements OnInit {
   }
 
   ngOnInit(): void {
-    this.store.dispatch(new actions.GetProjectsLoad());
+    this.store.dispatch(new actions.LoadProjects());
     const projects$ = this.store.pipe(select(allProjects));
 
     projects$.subscribe((response) => {