Torrent update menu with 5 items selections.

New torrent list can be added before or after the original tracker list inside the torrent files.
When there is a duplication conflict, delete it from the new or original list.
And there is the sort by name.
There are total 5 possibles way to update the end result list.

Author: GerryFerdinandus

source/main.lfm

@@ -302,15 +302,29 @@ object FormTrackerModify: TFormTrackerModify
       Caption = '&Update torrent'
       Hint = 'Update the torrent files'
       object MenuUpdateTorrentAddAfter: TMenuItem
-        Caption = 'Add new trackers &After original trackers (original trackers + new trackers)'
-        OnClick = MenuUpdateTorrentAddAfterClick
+        Caption = 'Insert new trackers list &BEFORE, the original trackers list inside the torrent file'
+        object MenuUpdateTorrentAddBeforeRemoveOriginal: TMenuItem
+          Caption = 'And remove possible duplicated trackers from the ORIGINAL trackers list.'
+          OnClick = MenuUpdateTorrentAddBeforeRemoveOriginalClick
+        end
+        object MenuUpdateTorrentAddBeforeRemoveNew: TMenuItem
+          Caption = 'And remove possible duplicated trackers from the NEW trackers list.'
+          OnClick = MenuUpdateTorrentAddBeforeRemoveNewClick
+        end
       end
       object MenuUpdateTorrentAddBefore: TMenuItem
-        Caption = 'Add new trackers &Before original trackers (new trackers + original trackers)'
-        OnClick = MenuUpdateTorrentAddBeforeClick
+        Caption = 'Append new trackers list &AFTER, the original trackers list inside the torrent file.'
+        object MenuUpdateTorrentAddAfterRemoveOriginal: TMenuItem
+          Caption = 'And remove possible duplicated trackers from the ORIGINAL trackers list.'
+          OnClick = MenuUpdateTorrentAddAfterRemoveOriginalClick
+        end
+        object MenuUpdateTorrentAddAfterRemoveNew: TMenuItem
+          Caption = 'And remove possible duplicated trackers from the NEW trackers list.'
+          OnClick = MenuUpdateTorrentAddAfterRemoveNewClick
+        end
       end
       object MenuUpdateTorrentSort: TMenuItem
-        Caption = '&Sort the trackers by name.'
+        Caption = '&Sort the trackers list by name.'
         OnClick = MenuUpdateTorrentSortClick
       end
     end

source/main.pas

@@ -42,7 +42,12 @@ interface
 type
 
   //Updated torrent file trackers list order.
-  TTrackerListOrder = (tloInsertBefore, tloAppendAfter, tloSort);
+  TTrackerListOrder = (
+    tloInsertNewBeforeAndKeepOriginalIntact,
+    tloInsertNewBeforeAndKeepNewIntact,
+    tloAppendNewAfterAndKeepOriginalIntact,
+    tloAppendNewAfterAndKeepNewIntact,
+    tloSort);
 
 
   { TFormTrackerModify }
@@ -60,6 +65,10 @@   TFormTrackerModify = class(TForm)
     MenuFileTorrentFolder: TMenuItem;
     MenuFileOpenTrackerList: TMenuItem;
     MenuHelpReportingIssue: TMenuItem;
+    MenuUpdateTorrentAddBeforeRemoveOriginal: TMenuItem;
+    MenuUpdateTorrentAddAfterRemoveOriginal: TMenuItem;
+    MenuUpdateTorrentAddBeforeRemoveNew: TMenuItem;
+    MenuUpdateTorrentAddAfterRemoveNew: TMenuItem;
     MenuUpdateTorrentSort: TMenuItem;
     MenuUpdateTorrentAddAfter: TMenuItem;
     MenuUpdateTorrentAddBefore: TMenuItem;
@@ -116,8 +125,10 @@   TFormTrackerModify = class(TForm)
     procedure MenuTrackersKeepOrDeleteAllTrackersClick(Sender: TObject);
 
     //Menu update torrent
-    procedure MenuUpdateTorrentAddAfterClick(Sender: TObject);
-    procedure MenuUpdateTorrentAddBeforeClick(Sender: TObject);
+    procedure MenuUpdateTorrentAddAfterRemoveNewClick(Sender: TObject);
+    procedure MenuUpdateTorrentAddAfterRemoveOriginalClick(Sender: TObject);
+    procedure MenuUpdateTorrentAddBeforeRemoveNewClick(Sender: TObject);
+    procedure MenuUpdateTorrentAddBeforeRemoveOriginalClick(Sender: TObject);
     procedure MenuUpdateTorrentSortClick(Sender: TObject);
 
   private
@@ -135,8 +146,7 @@   TFormTrackerModify = class(TForm)
     // All the torrent files that must be updated
     FTorrentFileNameList,
     //Log string text output
-    FLogStringList
-    : TStringList;
+    FLogStringList: TStringList;
     // is the present torrent file being process
     FDecodePresentTorrent: TDecodeTorrent;
     FConcoleMode, //user have start the program in console mode
@@ -499,10 +509,9 @@ procedure TFormTrackerModify.UpdateTorrent;
       if not FDecodePresentTorrent.DecodeTorrent(FTorrentFileNameList[i]) then
         Continue;
 
-      //tloInsertBefore and tloAppendAfter need the list be updated or each torrent file.
-      //for tloSort it is already process one time.
-      if (FTrackerListOrderForUpdatedTorrent = tloInsertBefore) or
-        (FTrackerListOrderForUpdatedTorrent = tloAppendAfter) then
+
+      //tloSort it is already process. But it not tloSort then process it.
+      if FTrackerListOrderForUpdatedTorrent <> tloSort then
       begin
         //Add the new tracker before of after the original trackers inside the torrent.
         CombineFiveTrackerListToOne(FTrackerListOrderForUpdatedTorrent);
@@ -898,7 +907,6 @@ procedure TFormTrackerModify.CombineFiveTrackerListToOne(
   TrackerDeselectTempList, TrackerFromInsideOneTorrentFile: TStringList;
 
 begin
-  //Must keep the original order of trackers inside the torrent file.
   //The new trackers can be added at the begin of end of the list.
 
   // FTrackerFinalList =
@@ -915,8 +923,7 @@ procedure TFormTrackerModify.CombineFiveTrackerListToOne(
     //Begin with an empty list
     FTrackerFinalList.Clear;
 
-    if (FTrackerListOrderForUpdatedTorrent = tloInsertBefore) or
-      (FTrackerListOrderForUpdatedTorrent = tloAppendAfter) then
+    if FTrackerListOrderForUpdatedTorrent <> tloSort then
     begin
 
       //Read the trackers inside the torrent file
@@ -926,46 +933,80 @@ procedure TFormTrackerModify.CombineFiveTrackerListToOne(
         AddButIngnoreDuplicates(TrackerFromInsideOneTorrentFile, TrackerStr);
       end;
 
-      //Remove the trackers that we do not want, but these trackers can be posible added again.
-      RemoveTrackersFromList(FTrackerBanByUserList, TrackerFromInsideOneTorrentFile);
-      RemoveTrackersFromList(FTrackerManualyDeselectedByUserList,
-        TrackerFromInsideOneTorrentFile);
-
     end;
 
     //Add the new tracker list before of after the original trackers list inside the torrent file.
     case TrackerListOrder of
 
-      tloInsertBefore:
+      tloInsertNewBeforeAndKeepOriginalIntact:
+      begin
+        //Before
+
+        //Must be place as first FTrackerAddedByUserList (Not instact when duplicated)
+        for TrackerStr in FTrackerAddedByUserList do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+
+        //original tracker list is second place (Keep original intact)
+        RemoveTrackersFromList(TrackerFromInsideOneTorrentFile, FTrackerFinalList);
+        for TrackerStr in TrackerFromInsideOneTorrentFile do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+
+        //'Others' trackers added as last. (Not instact when duplicated)
+        for TrackerStr in FTrackerFromInsideTorrentFilesList do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+      end;
+
+
+      tloInsertNewBeforeAndKeepNewIntact:
       begin
         //Before
 
-        //Must be place as first FTrackerAddedByUserList
+        //Must be place as first FTrackerAddedByUserList (keep new instact)
         for TrackerStr in FTrackerAddedByUserList do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
 
-        //original tracker list is second place
+        //original tracker list is second place (Not instact when duplicated)
+        for TrackerStr in TrackerFromInsideOneTorrentFile do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+
+        //'Others' trackers added as last. (Not instact when duplicated)
+        for TrackerStr in FTrackerFromInsideTorrentFilesList do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+      end;
+
+
+      tloAppendNewAfterAndKeepOriginalIntact:
+      begin
+        //After
+
+        //original tracker list must be place first. (keep original instact)
         for TrackerStr in TrackerFromInsideOneTorrentFile do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
 
-        //'Others' trackers added as last.
+        //Must be place after TrackerFromInsideOneTorrentFile (Not instact when duplicated)
+        for TrackerStr in FTrackerAddedByUserList do
+          AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+
+        //'Others' trackers added as last.  (Not instact when duplicated)
         for TrackerStr in FTrackerFromInsideTorrentFilesList do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
+
       end;
 
-      tloAppendAfter:
+      tloAppendNewAfterAndKeepNewIntact:
       begin
         //After
 
-        //original tracker list must be place first.
+        //original tracker list must be place first. (Not instact when duplicated)
         for TrackerStr in TrackerFromInsideOneTorrentFile do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
 
-        //Must be place after TrackerFromInsideOneTorrentFile
+        //Must be place after TrackerFromInsideOneTorrentFile (keep new instact)
+        RemoveTrackersFromList(FTrackerAddedByUserList, FTrackerFinalList);
         for TrackerStr in FTrackerAddedByUserList do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
 
-        //'Others' trackers added as last.
+        //'Others' trackers added as last. (Not instact when duplicated)
         for TrackerStr in FTrackerFromInsideTorrentFilesList do
           AddButIngnoreDuplicates(FTrackerFinalList, TrackerStr);
 
@@ -996,16 +1037,17 @@ procedure TFormTrackerModify.CombineFiveTrackerListToOne(
     //Must keep FTrackerManualyDeselectedByUserList intact. Copy it to TrackerDeselectTempList
     TrackerDeselectTempList := TStringList.Create;
     TrackerDeselectTempList.Text := FTrackerManualyDeselectedByUserList.Text;
-
     RemoveTrackersFromList(FTrackerAddedByUserList, TrackerDeselectTempList);
 
     //Remove the trackers that we do not want in FTrackerFinalList must be the last step.
     RemoveTrackersFromList(FTrackerBanByUserList, FTrackerFinalList);
     RemoveTrackersFromList(TrackerDeselectTempList, FTrackerFinalList);
 
+    //No longer needed
     TrackerDeselectTempList.Free;
 
   finally
+    //No longer needed
     TrackerFromInsideOneTorrentFile.Free;
   end;
 end;
@@ -1015,6 +1057,7 @@ procedure TFormTrackerModify.UpdateTrackerInsideFileList;
 var
   i: integer;
 begin
+  //Collect data what the user want to keep
   //Copy items from CheckListBoxTrackersList to FTrackerFromInsideTorrentFilesList
   //Copy items from CheckListBoxTrackersList to FTrackerManualyDeselectedByUserList
 
@@ -1176,17 +1219,35 @@ procedure TFormTrackerModify.MenuTrackersKeepOrDeleteAllTrackersClick(Sender: TO
   CheckedOnOffAllTrackers(TMenuItem(Sender).Tag = 1);
 end;
 
-procedure TFormTrackerModify.MenuUpdateTorrentAddAfterClick(Sender: TObject);
+procedure TFormTrackerModify.MenuUpdateTorrentAddAfterRemoveNewClick(Sender: TObject);
+begin
+  //User have selected to add new tracker.
+  FTrackerListOrderForUpdatedTorrent := tloAppendNewAfterAndKeepOriginalIntact;
+  UpdateTorrent;
+end;
+
+procedure TFormTrackerModify.MenuUpdateTorrentAddAfterRemoveOriginalClick(
+  Sender: TObject);
 begin
-  //User can select to add new tracker before after the original
-  FTrackerListOrderForUpdatedTorrent := tloAppendAfter;
+  //User have selected to add new tracker.
+  FTrackerListOrderForUpdatedTorrent := tloAppendNewAfterAndKeepNewIntact;
   UpdateTorrent;
 end;
 
-procedure TFormTrackerModify.MenuUpdateTorrentAddBeforeClick(Sender: TObject);
+procedure TFormTrackerModify.MenuUpdateTorrentAddBeforeRemoveNewClick(Sender: TObject);
+
+
+begin
+  //User have selected to add new tracker.
+  FTrackerListOrderForUpdatedTorrent := tloInsertNewBeforeAndKeepOriginalIntact;
+  UpdateTorrent;
+end;
+
+procedure TFormTrackerModify.MenuUpdateTorrentAddBeforeRemoveOriginalClick(
+  Sender: TObject);
 begin
-  //User can select to add new tracker before after the original
-  FTrackerListOrderForUpdatedTorrent := tloInsertBefore;
+  //User have selected to add new tracker.
+  FTrackerListOrderForUpdatedTorrent := tloInsertNewBeforeAndKeepNewIntact;
   UpdateTorrent;
 end;