[Issue GerryFerdinandus#22] Wrong tracker URL format unselected

Wrong tracker URL format from
torrent files should be un-selected by default

Author: GerryFerdinandus

source/code/controler_trackerlist_online.pas

@@ -12,6 +12,8 @@ interface
 
 type
 
+  TDefaultChecked = function(const TrackerURL: UTF8String): Boolean of object;
+
   { TControlerTrackerListOnline }
 
   TControlerTrackerListOnline = class
@@ -20,6 +22,7 @@   TControlerTrackerListOnline = class
     FNewTrackon: TNewTrackon;
     FTrackerListOnline: TTrackerListOnline;
     FTrackerList: TStringList;
+    FDefaultChecked: TDefaultChecked;
 
     //The collumn must be in this design order.
     FSelect,               //< 0
@@ -33,7 +36,6 @@   TControlerTrackerListOnline = class
     procedure AppendRow(Checked: boolean; Status: TTrackerListOnlineStatus;
       const TrackerURL: UTF8String);
   public
-
     property Checked[index: integer]: boolean read GetChecked write SetChecked;
     function TrackerURL(index: integer): string;
     function TrackerStatus(index: integer): TTrackerListOnlineStatus;
@@ -45,7 +47,7 @@   TControlerTrackerListOnline = class
 
     function DownloadTrackers: boolean;
 
-    constructor Create(StringGridTorrentURL: TStringGrid; TrackerList: TStringList);
+    constructor Create(StringGridTorrentURL: TStringGrid; TrackerList: TStringList; DefaultChecked: TDefaultChecked);
     destructor Destroy; override;
   end;
 
@@ -65,10 +67,11 @@ function TControlerTrackerListOnline.DownloadTrackers: boolean;
 end;
 
 constructor TControlerTrackerListOnline.Create(StringGridTorrentURL: TStringGrid;
-  TrackerList: TStringList);
+  TrackerList: TStringList; DefaultChecked: TDefaultChecked);
 begin
 
   FTrackerList := TrackerList;
+  FDefaultChecked := DefaultChecked;
 
   FStringGridTorrentURL := StringGridTorrentURL;
   FStringGridTorrentURL.RowCount := 1;
@@ -165,20 +168,16 @@ function TControlerTrackerListOnline.StableTrackers: TStringList;
 procedure TControlerTrackerListOnline.UpdateView;
 var
   tracker: string;
-  DeafultChecked: boolean;
 begin
   //Clear all the previeus data in the view
   FStringGridTorrentURL.RowCount := FStringGridTorrentURL.FixedRows;
 
-  //the default status is is put all the checkox to true. => keep all trackers
-  DeafultChecked := True;
-
   FStringGridTorrentURL.BeginUpdate;
 
   //Show the TrackerList list in string grid view
   for tracker in FTrackerList do
   begin
-    AppendRow(DeafultChecked, FTrackerListOnline.TrackerStatus(tracker), tracker);
+    AppendRow(FDefaultChecked(tracker), FTrackerListOnline.TrackerStatus(tracker), tracker);
   end;
 
   //make sure all text are fit inside the columns

source/code/main.pas

@@ -150,6 +150,7 @@   TFormTrackerModify = class(TForm)
     FTreeNodeRoot: TTreeNode;
     FControlerGridTorrentData: TControlerGridTorrentData;
 
+    function TrackerWithURLAndAnnounce(const TrackerURL: UTF8String): boolean;
     procedure UpdateTorrent;
     procedure ShowHourGlassCursor(HourGlass: boolean);
     procedure ViewUpdateBegin(ClearView: boolean = True);
@@ -263,8 +264,7 @@ procedure TFormTrackerModify.FormCreate(Sender: TObject);
   //Create view for trackerURL with checkbox
   FControlerTrackerListOnline :=
     TControlerTrackerListOnline.Create(StringGridTrackerOnline,
-    FTrackerList.TrackerFromInsideTorrentFilesList);
-
+    FTrackerList.TrackerFromInsideTorrentFilesList, @TrackerWithURLAndAnnounce);
 
   //start the program at mimimum visual size. (this is optional)
   Width := Constraints.MinWidth;
@@ -376,6 +376,12 @@ procedure TFormTrackerModify.MenuItemOnlineCheckDownloadNewTrackonClick(
   end;
 end;
 
+function TFormTrackerModify.TrackerWithURLAndAnnounce(
+  const TrackerURL: UTF8String): boolean;
+begin
+  Result := ValidTrackerURL(TrackerURL) and TrackerURLWithAnnounce(TrackerURL);
+end;
+
 procedure TFormTrackerModify.MenuTrackersDeleteTrackersWithStatusClick(
   Sender: TObject);
 
@@ -822,8 +828,6 @@ procedure TFormTrackerModify.ConsoleMode;
         begin
           //Show all the tracker inside the torrent files.
           ShowTrackerInsideFileList;
-          //Mark all trackers as selected
-          CheckedOnOffAllTrackers(True);
           //Some tracker must be removed. Console and windows mode.
           UpdateViewRemoveTracker;
           //update torrent
@@ -844,8 +848,6 @@ procedure TFormTrackerModify.ConsoleMode;
             begin
               //Show all the tracker inside the torrent files.
               ShowTrackerInsideFileList;
-              //Mark all trackers as selected
-              CheckedOnOffAllTrackers(True);
               //Some tracker must be removed. Console and windows mode.
               UpdateViewRemoveTracker;
               //update torrent
@@ -1730,8 +1732,6 @@ procedure TFormTrackerModify.ViewUpdateEnd;
 
   //Show all the tracker inside the torrent files.
   ShowTrackerInsideFileList;
-  //Mark all trackers as selected
-  CheckedOnOffAllTrackers(True);
   //Some tracker must be removed. Console and windows mode.
   UpdateViewRemoveTracker;