From ab706d2b7daa6364e32013755477d36b42d13d80 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 8 Jul 2021 14:27:14 -0500 Subject: [PATCH 1/5] chore(deps): update dependency semantic-release to v17.4.4 (#382) Co-authored-by: Renovate Bot --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 90eb43d3..1ddbc22c 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "devDependencies": { "@webtorrent/semantic-release-config": "1.0.5", "magnet-uri": "6.2.0", - "semantic-release": "17.4.3", + "semantic-release": "17.4.4", "standard": "*", "tape": "5.2.2", "webtorrent-fixtures": "1.7.3", From 8a23ccdcdfcf233a7fab4c5611bfba4d0fe8c470 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Rodr=C3=ADguez=20Baquero?= Date: Wed, 21 Jul 2021 19:44:23 -0500 Subject: [PATCH 2/5] Delete stale.yml --- .github/stale.yml | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .github/stale.yml diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index 0d0b1c99..00000000 --- a/.github/stale.yml +++ /dev/null @@ -1 +0,0 @@ -_extends: .github From 4699cc2da716f05eb45f812c8045713a89a41e61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Rodr=C3=ADguez=20Baquero?= Date: Wed, 21 Jul 2021 19:44:41 -0500 Subject: [PATCH 3/5] chore: add stale --- .github/workflows/stale.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/stale.yml diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml new file mode 100644 index 00000000..72597d8e --- /dev/null +++ b/.github/workflows/stale.yml @@ -0,0 +1,23 @@ +name: Mark stale issues and pull requests + +on: + schedule: + - cron: '0 12 * * *' + +jobs: + stale: + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + + steps: + - uses: actions/stale@v4 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + stale-issue-message: 'Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?' + stale-pr-message: 'Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?' + exempt-issue-labels: accepted,blocked,bug,dependency,enhancement,'help wanted',question,security,meta + exempt-pr-labels: accepted,blocked,bug,dependency,enhancement,'help wanted',question,security,meta + stale-issue-label: 'stale' + stale-pr-label: 'stale' From ca88435617e59714a456031c75b3a329897d97bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Rodr=C3=ADguez=20Baquero?= Date: Wed, 21 Jul 2021 20:07:06 -0500 Subject: [PATCH 4/5] fix: if websocket closed, don't produce a response --- lib/server/swarm.js | 1 + server.js | 2 +- test/request-handler.js | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/server/swarm.js b/lib/server/swarm.js index e1229c9f..8194270f 100644 --- a/lib/server/swarm.js +++ b/lib/server/swarm.js @@ -42,6 +42,7 @@ class Swarm { self._onAnnounceStarted(params, peer, id) } else if (params.event === 'stopped') { self._onAnnounceStopped(params, peer, id) + if (!cb) return // when websocket is closed } else if (params.event === 'completed') { self._onAnnounceCompleted(params, peer, id) } else if (params.event === 'update') { diff --git a/server.js b/server.js index a72b3391..3bdbea71 100644 --- a/server.js +++ b/server.js @@ -588,7 +588,7 @@ class Server extends EventEmitter { event: 'stopped', numwant: 0, peer_id: socket.peerId - }, noop) + }) } }) } diff --git a/test/request-handler.js b/test/request-handler.js index 7e5e967e..b60f9674 100644 --- a/test/request-handler.js +++ b/test/request-handler.js @@ -14,10 +14,10 @@ function testRequestHandler (t, serverType) { class Swarm extends Server.Swarm { announce (params, cb) { super.announce(params, (err, response) => { - if (err) return cb(response) + if (cb && err) return cb(response) response.complete = 246 response.extraData = 'hi' - cb(null, response) + if (cb) cb(null, response) }) } } From 22acc4d13c8808124d7fe1dda8d72323f63aa32a Mon Sep 17 00:00:00 2001 From: semantic-release-bot Date: Thu, 22 Jul 2021 01:07:57 +0000 Subject: [PATCH 5/5] chore(release): 9.17.4 ## [9.17.4](https://github.com/webtorrent/bittorrent-tracker/compare/v9.17.3...v9.17.4) (2021-07-22) ### Bug Fixes * if websocket closed, don't produce a response ([ca88435](https://github.com/webtorrent/bittorrent-tracker/commit/ca88435617e59714a456031c75b3a329897d97bd)) --- AUTHORS.md | 1 + CHANGELOG.md | 7 +++++++ package.json | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/AUTHORS.md b/AUTHORS.md index 3f271ad0..25ff8e66 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -55,5 +55,6 @@ - Diego Rodríguez Baquero (diego@mothership.com) - Diego Rodriguez Baquero (diego@arc.io) - semantic-release-bot (semantic-release-bot@martynus.net) +- renovate[bot] (29139614+renovate[bot]@users.noreply.github.com) #### Generated by tools/update-authors.sh. diff --git a/CHANGELOG.md b/CHANGELOG.md index 9abef049..9fdc423e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +## [9.17.4](https://github.com/webtorrent/bittorrent-tracker/compare/v9.17.3...v9.17.4) (2021-07-22) + + +### Bug Fixes + +* if websocket closed, don't produce a response ([ca88435](https://github.com/webtorrent/bittorrent-tracker/commit/ca88435617e59714a456031c75b3a329897d97bd)) + ## [9.17.3](https://github.com/webtorrent/bittorrent-tracker/compare/v9.17.2...v9.17.3) (2021-07-02) diff --git a/package.json b/package.json index 1ddbc22c..4557c3ad 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "bittorrent-tracker", "description": "Simple, robust, BitTorrent tracker (client & server) implementation", - "version": "9.17.3", + "version": "9.17.4", "author": { "name": "WebTorrent LLC", "email": "feross@webtorrent.io",