Merge pull request #11 from typinghard/sonarcloud_initial

Initial changes to run sonarqube on sonarcloud

Author: DiegoGalante

.gitignore

@@ -348,3 +348,9 @@ MigrationBackup/
 
 # Ionide (cross platform F# VS Code tools) working folder
 .ionide/
+
+.sonarqube
+
+*.bat
+
+*.xml

adt_pull_request.yml

@@ -10,67 +10,29 @@ steps:
     organization: typinghard
     projectKey: 'typinghard_azure-devops-tracker'
     extraProperties: |
-     # Additional properties that will be passed to the scanner, 
-     # Put one key=value per line, example:
-     # sonar.exclusions=**/*.bin
-     #sonar.coverageReportPaths=$(Agent.TempDirectory)/**/*.trx
-     #sonar.cs.opencover.reportsPaths=$(Agent.TempDirectory)/**/*.trx
-     #sonar.coverageReportPaths=$(Agent.TempDirectory)/reports/SonarQube.xml
-     #sonar.cs.dotcover.reportsPaths=$(Agent.TempDirectory)/reports/DetailedXML.xml
-     sonar.cs.opencover.reportsPaths=$(Build.SourcesDirectory)/**/coverage.opencover.xml
-     sonar.cs.vstest.reportsPaths=$(Agent.TempDirectory)/**/*.trx
-     sonar.cs.opencover.reportsPaths=$(Agent.TempDirectory)\**\*.trx
-     sonar.cs.vstest.reportsPaths=$(Agent.TempDirectory)\**\*.trx
-     sonar.cs.vscoveragexml.reportsPaths=$(Agent.TempDirectory)\**\*.coveragexml
-     sonar.cs.vscoveragexml.reportsPaths=coverage.xml
-     sonar.cs.opencover.reportsPaths=coverage.xml
-     sonar.verbose=true
-
+     sonar.exclusions=**/obj/**,**/*.dll
+     sonar.cs.opencover.reportsPaths=$(Agent.TempDirectory)/**/coverage.opencover.xml
+     sonar.cs.vstest.reportsPaths=$(Agent.TempDirectory)/*.trx
 
 - task: CmdLine@2
   inputs:
     script: dotnet restore
-  displayName: 'Rodando dotnet restore'
+  displayName: 'Run dotnet restore'
 
 - task: CmdLine@2
   inputs:
     script: dotnet build --no-incremental
-  displayName: 'Rodando dotnet build'
-
-- task: DotNetCoreCLI@2
-  displayName: 'Rodando dotnet test'
-  inputs:
-    command: test
-    projects: '**/*[Tt]ests/*.csproj'
-    arguments: '--configuration $(BuildConfiguration) /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --collect "Code Coverage"'
+  displayName: 'Run dotnet build'
 
 - script: 'dotnet tool install --global coverlet.console'  
   displayName: 'Install coverlet global tool'  
 
-#- script: 'reportgenerator -reports:$(Agent.TempDirectory)/**/coverage.cobertura.xml -targetdir:$(Build.SourcesDirectory)/coverlet/reports -reporttypes:"Cobertura"'  
-#  displayName: 'Create reports'
-
-- script: coverlet *.Tests.dll --target "dotnet"  --targetargs "test --no-build" -f=opencover  -o="coverage.xml"
-  displayName: 'Run coverlet'  
-
-- task: PublishTestResults@2
-  inputs:
-    testResultsFormat: 'VSTest'
-    testResultsFiles: '$(Agent.TempDirectory)/**.*trx'
-
-#- task: Palmmedia.reportgenerator.reportgenerator-build-release-task.reportgenerator@5
-#  displayName: ReportGenerator
-#  inputs:
-#    reports: '$(Agent.TempDirectory)/coverage.cobertura.xml'
-#    targetdir: '$(Build.SourcesDirectory)/reports'
-#    reporttypes: 'SonarQube'
-#    assemblyfilters: '-xunit\*'
-
-- task: PublishCodeCoverageResults@1
-  displayName: 'Publish code coverage from $(Build.SourcesDirectory)/coverage.xml'
+- task: DotNetCoreCLI@2
+  displayName: 'Run dotnet test'
   inputs:
-    codeCoverageTool: Cobertura
-    summaryFileLocation: '$(Build.SourcesDirectory)/coverage.xml'
+    command: test
+    projects: '**/*[Tt]ests/*.csproj'
+    arguments: '--configuration $(BuildConfiguration) /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --collect "Code Coverage" /p:Exclude=[xunit.*]*'
 
 - task: SonarSource.sonarcloud.ce096e50-6155-4de8-8800-4221aaeed4a1.SonarCloudAnalyze@1
   displayName: 'Run Code Analysis'

src/Adapters/WorkItemAdapter.cs

@@ -1,4 +1,4 @@
-using AzureDevopsTracker.DTOs;
+using AzureDevopsTracker.Dtos;
 using AzureDevopsTracker.Entities;
 using AzureDevopsTracker.Extensions;
 using AzureDevopsTracker.Interfaces;
@@ -10,11 +10,11 @@ namespace AzureDevopsTracker.Adapters
 {
     internal class WorkItemAdapter : IWorkItemAdapter
     {
-        public WorkItemDTO ToWorkItemDTO(WorkItem workItem)
+        public WorkItemDto ToWorkItemDto(WorkItem workItem)
         {
             if (workItem is null) return null;
 
-            return new WorkItemDTO()
+            return new WorkItemDto()
             {
                 Id = workItem.Id,
                 CreatedAt = workItem.CreatedAt,
@@ -32,30 +32,30 @@ public WorkItemDTO ToWorkItemDTO(WorkItem workItem)
                 WorkItemParentId = workItem.WorkItemParentId,
                 Activity = workItem.Activity,
                 Tags = workItem.Tags is null ? new List<string>() : workItem.Tags.Split(';').ToList(),
-                WorkItemsChangesDTO = ToWorkItemsChangeDTO(workItem.WorkItemsChanges.OrderBy(x => x.CreatedAt).ToList()),
-                TimesByStateDTO = ToTimeByStatesDTO(workItem.CalculateTotalTimeByState().ToList()),
+                WorkItemsChangesDto = ToWorkItemsChangeDto(workItem.WorkItemsChanges.OrderBy(x => x.CreatedAt).ToList()),
+                TimesByStateDto = ToTimeByStatesDto(workItem.CalculateTotalTimeByState().ToList()),
             };
         }
 
-        public List<WorkItemDTO> ToWorkItemsDTO(List<WorkItem> workItems)
+        public List<WorkItemDto> ToWorkItemsDto(List<WorkItem> workItems)
         {
-            var workItemsDTO = new List<WorkItemDTO>();
+            var workItemsDto = new List<WorkItemDto>();
 
-            if (workItems is null) return workItemsDTO;
+            if (workItems is null) return workItemsDto;
 
             workItems.ForEach(
                         workItem =>
-                        workItemsDTO.Add(ToWorkItemDTO(workItem)));
+                        workItemsDto.Add(ToWorkItemDto(workItem)));
 
-            return workItemsDTO
+            return workItemsDto
                      .ToList();
         }
 
-        public WorkItemChangeDTO ToWorkItemChangeDTO(WorkItemChange workIteChange)
+        public WorkItemChangeDto ToWorkItemChangeDto(WorkItemChange workIteChange)
         {
             if (workIteChange is null) return null;
 
-            return new WorkItemChangeDTO()
+            return new WorkItemChangeDto()
             {
                 NewDate = workIteChange.NewDate,
                 NewState = workIteChange.NewState,
@@ -65,26 +65,26 @@ public WorkItemChangeDTO ToWorkItemChangeDTO(WorkItemChange workIteChange)
             };
         }
 
-        public List<WorkItemChangeDTO> ToWorkItemsChangeDTO(List<WorkItemChange> workItemsChanges)
+        public List<WorkItemChangeDto> ToWorkItemsChangeDto(List<WorkItemChange> workItemsChanges)
         {
-            var workItemsChangeDTO = new List<WorkItemChangeDTO>();
+            var workItemsChangeDto = new List<WorkItemChangeDto>();
 
-            if (workItemsChanges is null) return workItemsChangeDTO;
+            if (workItemsChanges is null) return workItemsChangeDto;
 
             workItemsChanges.ForEach(
                         workItemsChange =>
-                        workItemsChangeDTO.Add(ToWorkItemChangeDTO(workItemsChange)));
+                        workItemsChangeDto.Add(ToWorkItemChangeDto(workItemsChange)));
 
-            return workItemsChangeDTO
+            return workItemsChangeDto
                      .Where(w => w is not null)
                      .ToList();
         }
 
-        public TimeByStateDTO ToTimeByStateDTO(TimeByState workItemStatusTime)
+        public TimeByStateDto ToTimeByStateDto(TimeByState workItemStatusTime)
         {
             if (workItemStatusTime is null) return null;
 
-            return new TimeByStateDTO()
+            return new TimeByStateDto()
             {
                 CreatedAt = workItemStatusTime.CreatedAt,
                 State = workItemStatusTime.State,
@@ -93,17 +93,17 @@ public TimeByStateDTO ToTimeByStateDTO(TimeByState workItemStatusTime)
             };
         }
 
-        public List<TimeByStateDTO> ToTimeByStatesDTO(List<TimeByState> workItemStatusTimes)
+        public List<TimeByStateDto> ToTimeByStatesDto(List<TimeByState> workItemStatusTimes)
         {
-            var workItemStatusTimeDTO = new List<TimeByStateDTO>();
+            var workItemStatusTimeDto = new List<TimeByStateDto>();
 
-            if (workItemStatusTimes is null) return workItemStatusTimeDTO;
+            if (workItemStatusTimes is null) return workItemStatusTimeDto;
 
             workItemStatusTimes.ForEach(
                         workItemStatusTime =>
-                        workItemStatusTimeDTO.Add(ToTimeByStateDTO(workItemStatusTime)));
+                        workItemStatusTimeDto.Add(ToTimeByStateDto(workItemStatusTime)));
 
-            return workItemStatusTimeDTO
+            return workItemStatusTimeDto
                      .Where(w => w is not null)
                      .ToList();
         }

src/DTOs/Create/CreateWorkItemDTO.cs

@@ -1,9 +1,9 @@
 using Newtonsoft.Json;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs.Create
+namespace AzureDevopsTracker.Dtos.Create
 {
-    public record CreateWorkItemDTO
+    public record CreateWorkItemDto
     {
         [JsonPropertyName("resource")]
         [JsonProperty("resource")]

src/DTOs/Delete/DeleteWorkItemDTO.cs

@@ -1,9 +1,9 @@
 using Newtonsoft.Json;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs.Delete
+namespace AzureDevopsTracker.Dtos.Delete
 {
-    public record DeleteWorkItemDTO
+    public record DeleteWorkItemDto
     {
         [JsonPropertyName("resource")]
         [JsonProperty("resource")]

src/DTOs/Fields.cs

@@ -2,7 +2,7 @@
 using System;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs
+namespace AzureDevopsTracker.Dtos
 {
     public record Fields
     {

src/DTOs/Resource.cs

@@ -1,7 +1,7 @@
 using Newtonsoft.Json;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs
+namespace AzureDevopsTracker.Dtos
 {
     public record Resource
     {

src/DTOs/Restore/RestoreWorkItemDTO.cs

@@ -1,9 +1,9 @@
 using Newtonsoft.Json;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs.Restore
+namespace AzureDevopsTracker.Dtos.Restore
 {
-    public record RestoreWorkItemDTO
+    public record RestoreWorkItemDto
     {
         [JsonPropertyName("resource")]
         [JsonProperty("resource")]

src/DTOs/Update/UpdateWorkItemDTO.cs

@@ -2,9 +2,9 @@
 using System;
 using System.Text.Json.Serialization;
 
-namespace AzureDevopsTracker.DTOs.Update
+namespace AzureDevopsTracker.Dtos.Update
 {
-    public record UpdatedWorkItemDTO
+    public record UpdatedWorkItemDto
     {
         [JsonPropertyName("resource")]
         [JsonProperty("resource")]

src/DTOs/WorkItemDTO.cs

@@ -2,9 +2,9 @@
 using System;
 using System.Collections.Generic;
 
-namespace AzureDevopsTracker.DTOs
+namespace AzureDevopsTracker.Dtos
 {
-    public record WorkItemDTO
+    public record WorkItemDto
     {
         [JsonProperty("id")]
         public string Id { get; init; }
@@ -55,13 +55,13 @@ public record WorkItemDTO
         public IEnumerable<string> Tags { get; init; }
 
         [JsonProperty("workItems_changes")]
-        public List<WorkItemChangeDTO> WorkItemsChangesDTO { get; init; }
+        public List<WorkItemChangeDto> WorkItemsChangesDto { get; init; }
 
         [JsonProperty("times_by_state")]
-        public List<TimeByStateDTO> TimesByStateDTO { get; init; }
+        public List<TimeByStateDto> TimesByStateDto { get; init; }
     }
 
-    public record WorkItemChangeDTO
+    public record WorkItemChangeDto
     {
         [JsonProperty("new_date")]
         public DateTime NewDate { get; init; }
@@ -80,7 +80,7 @@ public record WorkItemChangeDTO
     }
 
 
-    public record TimeByStateDTO
+    public record TimeByStateDto
     {
         [JsonProperty("created_at")]
         public DateTime CreatedAt { get; init; }