Skip to content

Commit 8532426

Browse files
committed
Use anonymous functions
- allows overriding `onHttpRequest` on the tracker instance, instead of only on the prototype - plus, better perf (in theory)
1 parent 8d9da24 commit 8532426

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

server.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ function Server (opts) {
6161
// start an http tracker unless the user explictly says no
6262
if (opts.http !== false) {
6363
self.http = http.createServer()
64-
self.http.on('request', self.onHttpRequest.bind(self))
65-
self.http.on('error', self._onError.bind(self))
64+
self.http.on('request', function (req, res) { self.onHttpRequest(req, res) })
65+
self.http.on('error', function (err) { self._onError(err) })
6666
self.http.on('listening', onListening)
6767
}
6868

@@ -73,28 +73,28 @@ function Server (opts) {
7373
self.udp4 = self.udp = dgram.createSocket(
7474
isNode10 ? 'udp4' : { type: 'udp4', reuseAddr: true }
7575
)
76-
self.udp4.on('message', self.onUdpRequest.bind(self))
77-
self.udp4.on('error', self._onError.bind(self))
76+
self.udp4.on('message', function (msg, rinfo) { self.onUdpRequest(msg, rinfo) })
77+
self.udp4.on('error', function (err) { self._onError(err) })
7878
self.udp4.on('listening', onListening)
7979

8080
self.udp6 = dgram.createSocket(
8181
isNode10 ? 'udp6' : { type: 'udp6', reuseAddr: true }
8282
)
83-
self.udp6.on('message', self.onUdpRequest.bind(self))
84-
self.udp6.on('error', self._onError.bind(self))
83+
self.udp6.on('message', function (msg, rinfo) { self.onUdpRequest(msg, rinfo) })
84+
self.udp6.on('error', function (err) { self._onError(err) })
8585
self.udp6.on('listening', onListening)
8686
}
8787

8888
// start a websocket tracker (for WebTorrent) unless the user explicitly says no
8989
if (opts.ws === true) {
9090
if (!self.http) {
9191
self.http = http.createServer()
92-
self.http.on('error', self._onError.bind(self))
92+
self.http.on('error', function (err) { self._onError(err) })
9393
self.http.on('listening', onListening)
9494
}
9595
self.ws = new WebSocketServer({ server: self.http })
96-
self.ws.on('error', self._onError.bind(self))
97-
self.ws.on('connection', self.onWebSocketConnection.bind(self))
96+
self.ws.on('error', function (err) { self._onError(err) })
97+
self.ws.on('connection', function (socket) { self.onWebSocketConnection(socket) })
9898
}
9999

100100
var num = !!self.http + !!self.udp4 + !!self.udp6

0 commit comments

Comments
 (0)