From 9f3f949359c5dab1c537166edcea692dea5765f0 Mon Sep 17 00:00:00 2001
From: Jose Celano <josecelano@gmail.com>
Date: Tue, 9 Jan 2024 18:44:11 +0000
Subject: [PATCH 1/2] fix: [#592] halt channel closed after starting HTTP
 tracker

---
 src/bootstrap/jobs/http_tracker.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/bootstrap/jobs/http_tracker.rs b/src/bootstrap/jobs/http_tracker.rs
index 79e01fb3d..69ff345db 100644
--- a/src/bootstrap/jobs/http_tracker.rs
+++ b/src/bootstrap/jobs/http_tracker.rs
@@ -59,6 +59,10 @@ async fn start_v1(socket: SocketAddr, tls: Option<RustlsConfig>, tracker: Arc<co
         .expect("it should be able to start to the http tracker");
 
     tokio::spawn(async move {
+        assert!(
+            !server.state.halt_task.is_closed(),
+            "Halt channel for HTTP tracker should be open"
+        );
         server
             .state
             .task

From ba4cb3475fba3047ffb47fa8340f1ce4f7801465 Mon Sep 17 00:00:00 2001
From: Jose Celano <josecelano@gmail.com>
Date: Tue, 9 Jan 2024 18:50:16 +0000
Subject: [PATCH 2/2] feat: improve logging for HTTP tracker bootstrapping

---
 src/servers/http/server.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/servers/http/server.rs b/src/servers/http/server.rs
index c3411ac06..904ccdcf5 100644
--- a/src/servers/http/server.rs
+++ b/src/servers/http/server.rs
@@ -6,6 +6,7 @@ use axum_server::tls_rustls::RustlsConfig;
 use axum_server::Handle;
 use derive_more::Constructor;
 use futures::future::BoxFuture;
+use log::info;
 use tokio::sync::oneshot::{Receiver, Sender};
 
 use super::v1::routes::router;
@@ -51,6 +52,9 @@ impl Launcher {
         ));
 
         let tls = self.tls.clone();
+        let protocol = if tls.is_some() { "https" } else { "http" };
+
+        info!(target: "HTTP Tracker", "Starting on: {protocol}://{}", address);
 
         let running = Box::pin(async {
             match tls {
@@ -67,6 +71,8 @@ impl Launcher {
             }
         });
 
+        info!(target: "HTTP Tracker", "Started on: {protocol}://{}", address);
+
         tx_start
             .send(Started { address })
             .expect("the HTTP(s) Tracker service should not be dropped");