From bc95fc4c841674d837064099fedf040e059a20b8 Mon Sep 17 00:00:00 2001 From: Jose Celano Date: Thu, 20 Feb 2025 16:08:57 +0000 Subject: [PATCH] docs: remove code-review comment We decided not to change it. - The returned value is simpler. - We force the initial peer to change so there is no confusion about what was the final announced peer. --- packages/tracker-core/src/announce_handler.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/tracker-core/src/announce_handler.rs b/packages/tracker-core/src/announce_handler.rs index cd2073857..cb48a321a 100644 --- a/packages/tracker-core/src/announce_handler.rs +++ b/packages/tracker-core/src/announce_handler.rs @@ -162,10 +162,6 @@ impl AnnounceHandler { remote_client_ip: &IpAddr, peers_wanted: &PeersWanted, ) -> Result { - // code-review: maybe instead of mutating the peer we could just return - // a tuple with the new peer and the announce data: (Peer, AnnounceData). - // It could even be a different struct: `StoredPeer` or `PublicPeer`. - self.whitelist_authorization.authorize(info_hash).await?; tracing::debug!("Before: {peer:?}");