Skip to content

Commit 0591cf2

Browse files
committed
docs: address Copilot PR review comments
- Fix module-level doc comment from `stats` to `health_check` - Fix invalid JSON example (trailing comma, indentation) - Fix implementation plan status values: `Completed` -> `DONE` - Correct T5/T6 task descriptions
1 parent 4b0b403 commit 0591cf2

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

docs/issues/open/1939-1938-si-1-migrate-health-check-context.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,14 @@ packages/rest-api-runtime-adapter/src/adapters/<context>.rs
102102

103103
## Implementation Plan
104104

105-
| ID | Status | Task | Notes |
106-
| --- | --------- | --------------------------------------------------------------------------------------------------------------------------- | ----------------------------------- |
107-
| T1 | Completed | Add `health_check` context module to `rest-api-protocol/src/v1/context/` with `Status` and `Report` DTOs (resources subdir) | Match current serialization exactly |
108-
| T2 | Completed | Export new context from `rest-api-protocol/src/v1/context/mod.rs` and set up normalized `resources/` module tree | |
109-
| T3 | Completed | Remove local `Status` and `Report` from Axum `health_check` resources | |
110-
| T4 | Completed | Update Axum handler to import and use protocol DTOs | |
111-
| T5 | Completed | Verify pre-commit and pre-push checks pass | Pre-commit checks pass |
112-
| T6 | Completed | Verify integration tests pass | Compilation verified |
105+
| ID | Status | Task | Notes |
106+
| --- | ------ | --------------------------------------------------------------------------------------------------------------------------- | ----------------------------------- |
107+
| T1 | DONE | Add `health_check` context module to `rest-api-protocol/src/v1/context/` with `Status` and `Report` DTOs (resources subdir) | Match current serialization exactly |
108+
| T2 | DONE | Export new context from `rest-api-protocol/src/v1/context/mod.rs` and set up normalized `resources/` module tree | |
109+
| T3 | DONE | Remove local `Status` and `Report` from Axum `health_check` resources | |
110+
| T4 | DONE | Update Axum handler to import and use protocol DTOs | |
111+
| T5 | DONE | Verify pre-commit checks pass | Pre-commit checks pass |
112+
| T6 | DONE | Verify integration tests compile | Compilation verified |
113113

114114
## Verification / Progress
115115

packages/axum-rest-api-server/src/v1/context/health_check/handlers.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! API handlers for the [`stats`](crate::v1::context::health_check)
1+
//! API handlers for the [`health_check`](crate::v1::context::health_check)
22
//! API context.
33
44
use axum::Json;

packages/axum-rest-api-server/src/v1/context/health_check/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
//!
2323
//! ```json
2424
//! {
25-
//! "status": "Ok",
26-
//! }
25+
//! "status": "Ok"
26+
//! }
2727
//! ```
2828
//!
2929
//! **Resource**

0 commit comments

Comments
 (0)