Added Moq dependency to the Tests project and added unit tests verifying validity of the PortfolioServiceImpl class

Author: topnax

Tests/Integration/Repository/MarketOrderTest.cs

@@ -37,13 +37,12 @@ public void Dispose()
     public class MarketOrderRepositoryTest : IClassFixture<SqlKataMarketOrderRepositoryFixture>
     {
         private SqlKataMarketOrderRepositoryFixture _marketOrderRepositoryFixture;
-        private readonly ITestOutputHelper _testOutputHelper;
 
+        // TODO test Delete method
         public MarketOrderRepositoryTest(SqlKataMarketOrderRepositoryFixture marketOrderRepositoryFixture,
             ITestOutputHelper testOutputHelper)
         {
             this._marketOrderRepositoryFixture = marketOrderRepositoryFixture;
-            this._testOutputHelper = testOutputHelper;
         }
 
         [Fact]

Tests/Integration/Repository/PortfolioEntryTest.cs

@@ -36,6 +36,7 @@ public class PortfolioEntryRepositoryTest : IClassFixture<SqlKataPortfolioEntryR
     {
         private SqlKataPortfolioEntryRepositoryFixture _portfolioEntryRepositoryFixture;
 
+        // TODO test Delete method
         public PortfolioEntryRepositoryTest(SqlKataPortfolioEntryRepositoryFixture marketOrderRepositoryFixture)
         {
             this._portfolioEntryRepositoryFixture = marketOrderRepositoryFixture;

Tests/Integration/Repository/PortfolioTest.cs

@@ -33,6 +33,7 @@ public class PortfolioTest : IClassFixture<SqlKataPortfolioRepositoryFixture>
     {
         private SqlKataPortfolioRepositoryFixture _portfolioRepositoryFixture;
 
+        // TODO test Delete method
         public PortfolioTest(SqlKataPortfolioRepositoryFixture portfolioRepositoryFixture)
         {
             this._portfolioRepositoryFixture = portfolioRepositoryFixture;

Tests/Tests.csproj

@@ -8,6 +8,7 @@
 
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
+        <PackageReference Include="Moq" Version="4.16.1" />
         <PackageReference Include="xunit" Version="2.4.1" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
@@ -26,6 +27,7 @@
     <ItemGroup>
       <ProjectReference Include="..\CryptoStatsSource\CryptoStatsSource.csproj" />
       <ProjectReference Include="..\Repository\Repository.csproj" />
+      <ProjectReference Include="..\Services\Services\Services.csproj" />
       <ProjectReference Include="..\Utils\Utils.csproj" />
     </ItemGroup>
 

Tests/Unit/Service/PortfolioServiceTest.cs

@@ -0,0 +1,98 @@
+using System.Collections.Generic;
+using Model;
+using Moq;
+using Repository;
+using Services;
+using Xunit;
+
+namespace Tests.Unit.Service
+{
+    public class PortfolioRepositoryTest
+    {
+        [Fact]
+        public void Create_CallsRepository()
+        {
+            // arrange
+            var portfolioToBeAdded = new Portfolio("Foo", "Bar", Currency.Eur, -1);
+            var repositoryMock = new Mock<IPortfolioRepository>();
+            repositoryMock.Setup(x => x.Add(It.Is<Portfolio>(portfolio => portfolio == portfolioToBeAdded))).Returns(1);
+            var service = new PortfolioServiceImpl(repositoryMock.Object);
+
+            // act
+            var portfolio = service.CreatePortfolio("Foo", "Bar", Currency.Eur);
+
+            // assert
+            Assert.Equal(portfolioToBeAdded with {Id = 1}, portfolio);
+        }
+
+        [Fact]
+        public void Get_CallsRepository()
+        {
+            // arrange
+            var portfolioToBeAdded = new Portfolio("Foo", "Bar", Currency.Eur, 1);
+            var repositoryMock = new Mock<IPortfolioRepository>();
+            repositoryMock.Setup(x => x.Get(It.IsAny<int>())).Returns(portfolioToBeAdded);
+            var service = new PortfolioServiceImpl(repositoryMock.Object);
+
+            // act
+            var portfolio = service.GetPortfolio(1);
+
+            // assert
+            Assert.Equal(portfolioToBeAdded, portfolio);
+        }
+
+        [Fact]
+        public void GetPortfolios_CallsRepository()
+        {
+            // arrange
+            var portfolioList = new List<Portfolio>
+            {
+                new("My new portfolio", "Lorem ipsum dolor sit amet", Currency.Czk),
+                new("My second portfolio", "Lorem ipsum dolor sit amet", Currency.Eur),
+                new("My third portfolio", "Lorem ipsum dolor sit amet", Currency.Usd)
+            };
+
+            var repositoryMock = new Mock<IPortfolioRepository>();
+            repositoryMock.Setup(x => x.GetAll()).Returns(portfolioList);
+            var service = new PortfolioServiceImpl(repositoryMock.Object);
+
+            // act
+            var portfolioListFetched = service.GetPortfolios();
+
+            // assert
+            Assert.Equal(portfolioList, portfolioListFetched);
+        }
+
+        [Fact]
+        public void Update_CallsRepository()
+        {
+            // arrange
+            var portfolioToBeUpdated = new Portfolio("Foo", "Bar", Currency.Eur, 1);
+            var repositoryMock = new Mock<IPortfolioRepository>();
+            repositoryMock.Setup(x => x.Update(It.IsAny<Portfolio>())).Returns(true);
+            var service = new PortfolioServiceImpl(repositoryMock.Object);
+
+            // act
+            var updated = service.UpdatePortfolio(portfolioToBeUpdated);
+
+            // assert
+            Assert.True(updated);
+        }
+
+        [Fact]
+        public void Delete_CallsRepository()
+        {
+            // arrange
+            var portfolioToBeUpdated = new Portfolio("Foo", "Bar", Currency.Eur, 1);
+            var repositoryMock = new Mock<IPortfolioRepository>();
+            repositoryMock.Setup(x => x.Delete(It.IsAny<Portfolio>())).Returns(true);
+            var service = new PortfolioServiceImpl(repositoryMock.Object);
+
+            // act
+            var delete = service.DeletePortfolio(portfolioToBeUpdated);
+
+            // assert
+            Assert.True(delete);
+        }
+    }
+}