Fixed an issue where market entries were fetched by cryptocurrency names instead of their IDs.

Changed CryptoNameResolver to CryptocurrencyResolver.

Author: topnax

CryptoStatsSource/CryptoNameResolver.cs

@@ -1,39 +1,40 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using CryptoStatsSource.model;
 
 namespace CryptoStatsSource
 {
-    public interface ICryptoNameResolver
+    public interface ICryptocurrencyResolver
     {
-        public Task<string> Resolve(string symbol);
+        public Task<Cryptocurrency> Resolve(string symbol);
 
         public Task Refresh();
     }
 
-    public class CryptoNameResolverImpl : ICryptoNameResolver
+    public class CryptocurrencyResolverImpl : ICryptocurrencyResolver
     {
         private ICryptoStatsSource _cryptoStatsSource;
-        private Dictionary<String, String> _symbolToNameMap;
+        private Dictionary<String, Cryptocurrency> _nameToCryptocurrencyDictionary;
 
-        public CryptoNameResolverImpl(ICryptoStatsSource cryptoStatsSource)
+        public CryptocurrencyResolverImpl(ICryptoStatsSource cryptoStatsSource)
         {
             _cryptoStatsSource = cryptoStatsSource;
         }
 
         public async Task Refresh()
         {
             // TODO improve this
-            _symbolToNameMap = new();
+            _nameToCryptocurrencyDictionary = new();
             (await _cryptoStatsSource.GetAvailableCryptocurrencies()).ForEach(c =>
-                _symbolToNameMap.TryAdd(c.Symbol, c.Name));
+                _nameToCryptocurrencyDictionary.TryAdd(c.Symbol, c));
         }
 
-        public async Task<string> Resolve(string symbol)
+        public async Task<Cryptocurrency> Resolve(string symbol)
         {
-            if (_symbolToNameMap?.GetValueOrDefault(symbol) == null) await Refresh();
+            if (_nameToCryptocurrencyDictionary?.GetValueOrDefault(symbol) == null) await Refresh();
 
-            return _symbolToNameMap.GetValueOrDefault(symbol, null);
+            return _nameToCryptocurrencyDictionary.GetValueOrDefault(symbol, null);
         }
     }
 }

CryptoStatsSource/Model/MarketEntry.cs

@@ -1,9 +1,14 @@
+using System.Text.Json;
 using Newtonsoft.Json;
 
 namespace CryptoStatsSource.model
 {
     public record MarketEntry(string Id, string Symbol, string Name, decimal CurrentPrice, long MarketCap,
-        [JsonProperty("price_change_24h")] float PriceChange24H, [JsonProperty("price_change_percentage_24h")] float PriceChangePercentage24H);
+        [JsonProperty("price_change_24h", NullValueHandling = NullValueHandling.Ignore)]
+        float? PriceChange24H = 0f,
+        [JsonProperty("price_change_percentage_24h", NullValueHandling = NullValueHandling.Ignore)]
+        float? PriceChangePercentage24H = 0f
+    );
 
     public record PriceEntry(string Id, string Symbol, string Name, decimal CurrentPrice,
         float PriceChangePercentage24H);

Tests/Integration/CryptoStatsSource/CryptoNameResolverTest.cs

@@ -6,7 +6,7 @@ namespace Tests.Integration.CryptoStatsSource
     public class ResolveNameTest
     {
         private readonly CoingeckoSource _source;
-        private readonly CryptoNameResolverImpl _resolver;
+        private readonly CryptocurrencyResolverImpl _resolver;
 
         public ResolveNameTest()
         {
@@ -17,10 +17,10 @@ public ResolveNameTest()
         [Fact]
         public async void SimpleThreeEntries()
         {
-            Assert.Equal("Bitcoin", await _resolver.Resolve("btc"));
-            Assert.Equal("Cardano", await _resolver.Resolve("ada"));
-            Assert.Equal("Litecoin", await _resolver.Resolve("ltc"));
-            Assert.Equal("Ethereum", await _resolver.Resolve("eth"));
+            Assert.Equal(new("btc", "btc", "Bitcoin"), await _resolver.Resolve("btc"));
+            Assert.Equal(new ("ada", "ada", "Cardano"), await _resolver.Resolve("ada"));
+            Assert.Equal(new ("ltc", "ltc", "Litecoin"), await _resolver.Resolve("ltc"));
+            Assert.Equal(new("eth", "eth", "Ethereum"), await _resolver.Resolve("eth"));
             Assert.Null(await _resolver.Resolve("abcefghbzbzrfoo"));
         }
     }

WebFrontend/Pages/PortfolioDetail.razor

@@ -11,7 +11,7 @@
 @inject IMarketOrderService MarketOrderService;
 @inject ICryptoStatsSource CryptoStatsSource;
 @inject ISummaryService SummaryService;
-@inject ICryptoNameResolver CryptoNameResolver;
+@inject ICryptocurrencyResolver CryptocurrencyResolver;
 
 <style>
     .demo-mat-card {
@@ -140,15 +140,15 @@
     private async void _loadEntryInfo()
     {
         // resolve names of all portfolio entries 
-        await CryptoNameResolver.Refresh();
-        var portfolioEntriesNames = await Task.WhenAll(
+        await CryptocurrencyResolver.Refresh();
+        var portfolioCryptocurrencyEntries = await Task.WhenAll(
             ActivePortfolioEntries.Select(
-                async entry => (await CryptoNameResolver.Resolve(entry.Symbol)).ToLower())
+                async entry => (await CryptocurrencyResolver.Resolve(entry.Symbol)))
             );
 
         // fetch market entries of all entries of the portfolio 
         var marketEntries = await CryptoStatsSource.GetMarketEntries(
-            CurrencyUtils.GetCurrencyLabel(ActivePortfolio.Currency).ToLower(), portfolioEntriesNames
+            CurrencyUtils.GetCurrencyLabel(ActivePortfolio.Currency).ToLower(), portfolioCryptocurrencyEntries.Select(c => c.Id).ToArray()
             );
 
         // create a dictionary where a symbol is mapped to a market entry
@@ -191,13 +191,13 @@
 
         // create portfolio entry table rows
         PortfolioEntryRows = entrySummaries.Zip(ActivePortfolioEntries).Select(
-            (tuple) => new PortfolioEntryRow(
+            tuple => new PortfolioEntryRow(
                 // symbol of the portfolio entry
                 tuple.Second.Symbol,
                 // current price of the entry's asset 
                 symbolsToMarketEntries[tuple.Second.Symbol].CurrentPrice,
                 // asset's price change since the last 24h 
-                new decimal(symbolsToMarketEntries[tuple.Second.Symbol].PriceChangePercentage24H),
+                new decimal(symbolsToMarketEntries[tuple.Second.Symbol].PriceChangePercentage24H ?? 0),
                 // percentage within the portfolio entry
                 portfolioTotalMarketValue > 0 ? (tuple.First.MarketValue / portfolioTotalMarketValue) * 100 : 0,
                 // absolute change within the portfolio entry

WebFrontend/Pages/PortfolioEntryDetail.razor

@@ -10,7 +10,7 @@
 @inject IPortfolioService PortfolioService
 @inject IPortfolioEntryService PortfolioEntryService
 @inject IMarketOrderService MarketOrderService
-@inject ICryptoNameResolver CryptoNameResolver
+@inject ICryptocurrencyResolver CryptocurrencyResolver
 @inject ICryptoStatsSource CryptoStatsSource
 @inject ISummaryService SummaryService
 
@@ -50,9 +50,9 @@
                         <div class="demo-mat-card-content">
                             <MatHeadline6 class="clear-margin">
                                 <MatChipSet Style="align-items: center">
-                                    @if (PortfolioEntryName != null)
+                                    @if (PortfolioCryptocurrencyEntry != null)
                                     {
-                                        <MatH5 Class="clear-margin-vertical">@PortfolioEntryName</MatH5>
+                                        <MatH5 Class="clear-margin-vertical">@PortfolioCryptocurrencyEntry.Name</MatH5>
                                     }
                                     else
                                     {
@@ -216,7 +216,7 @@
     protected Portfolio ActivePortfolio;
     protected PortfolioEntry ActivePortfolioEntry; 
     protected MarketEntry CurrentEntryAssetMarketEntry; 
-    protected string PortfolioEntryName = "Bitcoin";
+    protected Cryptocurrency PortfolioCryptocurrencyEntry;
     protected ISummaryService.Summary EntrySummary;
     protected decimal TotalHoldings = 0;
 
@@ -237,7 +237,7 @@
     protected override async Task OnInitializedAsync()
     {
         // resolve the name of the cryptocurrency (using the symbol)
-         PortfolioEntryName = await CryptoNameResolver.Resolve(ActivePortfolioEntry.Symbol);
+         PortfolioCryptocurrencyEntry = await CryptocurrencyResolver.Resolve(ActivePortfolioEntry.Symbol);
 
         await UpdateEntrySummary();
     }
@@ -257,7 +257,7 @@
         // TODO null?
         CurrentEntryAssetMarketEntry = (await CryptoStatsSource.GetMarketEntries(
             CurrencyUtils.GetCurrencyLabel(ActivePortfolio.Currency).ToLower(),
-            PortfolioEntryName.ToLower()
+            PortfolioCryptocurrencyEntry.Id
             ))[0];
 
         // get all orders of the portfolio entry

WebFrontend/Startup.cs

@@ -53,7 +53,7 @@ public void ConfigureServices(IServiceCollection services)
             var db = new SqlKataDatabase(dbConnection, new SqliteCompiler());
             services.AddSingleton(ctx => db);
 
-            services.AddSingleton<ICryptoNameResolver, CryptoNameResolverImpl>();
+            services.AddSingleton<ICryptocurrencyResolver, CryptocurrencyResolverImpl>();
             services.AddSingleton<ISummaryService, SummaryServiceImpl>();
 
             services.AddSingleton<IPortfolioRepository, SqlKataPortfolioRepository>();