Implemented GetPorftolioSummary method and covered it with a unit test

Author: topnax

Services/Services/SummaryService.cs

@@ -14,7 +14,7 @@ public record Summary(decimal AbsoluteChange, decimal RelativeChange, decimal Ma
 
         public Summary GetPortfolioEntrySummary(List<MarketOrder> portfolioEntryOrders, decimal assetPrice);
 
-        public Summary GetPortfolioSummary(Portfolio portfolio, Dictionary<string, decimal> assetPriceMap);
+        public Summary GetPortfolioSummary(List<Summary> portfolioEntrySummaries);
     }
 
     public class SummaryServiceImpl : ISummaryService
@@ -42,7 +42,7 @@ public ISummaryService.Summary GetAverageOfSummaries(IEnumerable<ISummaryService
                 totalAbsoluteChange += summary.AbsoluteChange;
             }
 
-            decimal totalRelativeChange = (totalMarketValue / totalCost) / -1;
+            decimal totalRelativeChange = (totalMarketValue / totalCost) -1m;
 
             return new(totalAbsoluteChange, totalRelativeChange, totalMarketValue, totalCost);
         }
@@ -79,21 +79,7 @@ public ISummaryService.Summary GetPortfolioEntrySummary(List<MarketOrder> portfo
                 totalCost + totalFee);
         }
 
-        public ISummaryService.Summary GetPortfolioSummary(Portfolio portfolio,
-            Dictionary<string, decimal> assetPriceMap)
-        {
-            return null;
-            // var portfolioEntrySumarries = PortfolioEntryService.GetPortfolioEntries(portfolio.Id).Select(entry =>
-            // {
-            //     if (!assetPriceMap.TryGetValue(entry.Symbol, out var assetPrice))
-            //     {
-            //         throw new AssetPriceNotFoundException();
-            //     }
-
-            //     return GetPortfolioEntrySummary(entry, assetPrice);
-            // });
-            // return GetAverageOfSummaries(portfolioEntrySumarries);
-        }
+        public ISummaryService.Summary GetPortfolioSummary(List<ISummaryService.Summary> portfolioEntrySummaries) => GetAverageOfSummaries(portfolioEntrySummaries);
 
         public class AssetPriceNotFoundException : Exception
         {

Tests/Unit/Service/SummaryServiceTest.cs

@@ -92,14 +92,13 @@ public void GetMarketOrderSummary_WithFee_InLoss_Returns_Correct_Summary()
                 10001
             ), summary);
         }
-        
+
         // PortfolioEntrySummary tests
 
         [Fact]
         public void GetPortfolioEntrySummary_InProfit_Returns_Correct_Summary()
         {
             var service = new SummaryServiceImpl();
-            MarketOrder order = new(10000m, 1m, 1m, DateTime.Now, true);
             var summary = service.GetPortfolioEntrySummary(new()
             {
                 new(10000m, 0m, 1m, DateTime.Now, true),
@@ -118,7 +117,6 @@ public void GetPortfolioEntrySummary_InProfit_Returns_Correct_Summary()
         public void GetPortfolioEntrySummary_WithFee_InProfit_Returns_Correct_Summary()
         {
             var service = new SummaryServiceImpl();
-            MarketOrder order = new(10000m, 1m, 1m, DateTime.Now, true);
             var summary = service.GetPortfolioEntrySummary(new()
             {
                 new(10000m, 1m, 1m, DateTime.Now, true),
@@ -136,7 +134,6 @@ public void GetPortfolioEntrySummary_WithFee_InProfit_Returns_Correct_Summary()
         public void GetPortfolioEntrySummary_InProfit_WithSell_Returns_Correct_Summary()
         {
             var service = new SummaryServiceImpl();
-            MarketOrder order = new(10000m, 1m, 1m, DateTime.Now, true);
             var summary = service.GetPortfolioEntrySummary(new()
             {
                 new(10000m, 0m, 1m, DateTime.Now, true),
@@ -146,7 +143,7 @@ public void GetPortfolioEntrySummary_InProfit_WithSell_Returns_Correct_Summary()
 
             Assert.Equal(new ISummaryService.Summary(
                 1.5m * 40000m + 15000m - 30000m,
-                ((1.5m * 40000m  + 15000m - 30000m) / 30000m),
+                ((1.5m * 40000m + 15000m - 30000m) / 30000m),
                 1.5m * 40000m,
                 30000
             ), summary);
@@ -156,19 +153,34 @@ public void GetPortfolioEntrySummary_InProfit_WithSell_Returns_Correct_Summary()
         public void GetPortfolioEntrySummary_WithFee_InProfit_WithSell_Returns_Correct_Summary()
         {
             var service = new SummaryServiceImpl();
-            MarketOrder order = new(10000m, 1m, 1m, DateTime.Now, true);
             var summary = service.GetPortfolioEntrySummary(new()
             {
                 new(10000m, 1m, 1m, DateTime.Now, true),
                 new(20000m, 5m, 1m, DateTime.Now, true)
             }, 40000);
-            // currentTotalHoldingValue + totalSellValue - totalCost - totalFee
             Assert.Equal(new ISummaryService.Summary(
                 30000m + 20000m - 6,
                 ((80000m - 6m) / 30000m) - 1m,
                 80000m,
                 30006
             ), summary);
         }
+
+        // Portfolio summary tests
+
+        [Fact]
+        public void GetPortfolioSummary_Returns_Correct_Summary()
+        {
+            var service = new SummaryServiceImpl();
+            var summary = service.GetPortfolioSummary(new()
+            {
+                new(10000m, 1, 20000m, 10000),
+                new(2000m, 2, 3000m, 1000),
+            });
+            Assert.Equal(
+                new ISummaryService.Summary(12000m, (23000m / 11000m) - 1m, 23000m, 11000m),
+                summary
+            );
+        }
     }
 }