Started taking the total fee of a portfolio entry into consideration when calculating it's total relative change

Author: topnax

Services/Services/SummaryService.cs

@@ -89,7 +89,7 @@ public ISummaryService.Summary GetPortfolioEntrySummary(List<MarketOrder> portfo
             decimal currentTotalHoldingValue = totalHoldingSize * assetPrice;
 
             decimal totalAbsoluteChange = currentTotalHoldingValue + totalSellValue - totalCost - totalFee;
-            decimal totalRelativeChange = totalAbsoluteChange / totalCost;
+            decimal totalRelativeChange = totalAbsoluteChange / (totalCost + totalFee);
 
             return new ISummaryService.Summary(totalAbsoluteChange, totalRelativeChange, currentTotalHoldingValue,
                 totalCost + totalFee);

Tests/Unit/Service/SummaryServiceTest.cs

@@ -101,7 +101,7 @@ public void GetPortfolioEntrySummary_WithFee_InProfit_Returns_Correct_Summary()
             }, 40000);
             Assert.Equal(new ISummaryService.Summary(
                 30000m + 20000m - 6,
-                ((80000m - 6m) / 30000m) - 1m,
+                ((80000m) / (30000m + 6m)) - 1m,
                 80000m,
                 30006
             ), summary);
@@ -137,7 +137,7 @@ public void GetPortfolioEntrySummary_WithFee_InProfit_WithSell_Returns_Correct_S
             }, 40000);
             Assert.Equal(new ISummaryService.Summary(
                 30000m + 20000m - 6,
-                ((80000m - 6m) / 30000m) - 1m,
+                (80000m / (30000m + 6m)) - 1m,
                 80000m,
                 30006
             ), summary);