Skip to content

Commit 20df64c

Browse files
committed
Revert "Fix error with local.storage"
This reverts commit dd1a8dd.
1 parent dd1a8dd commit 20df64c

File tree

6 files changed

+23
-17
lines changed

6 files changed

+23
-17
lines changed

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
"name": "Web Activity Time Tracker",
55
"short_name": "Web Activity",
6-
"version": "0.6.3",
6+
"version": "0.6.0",
77

88
"minimum_chrome_version": "26",
99

options.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
</div>
6464
</div>
6565
<div id='aboutBlock' hidden>
66-
<div><label id='version'>v0.6.3</label></div>
66+
<div><label id='version'>v0.6.0</label></div>
6767
<div class="margin-top-20">
6868
<label>If experiencing problems, having questions or suggestions, please fill out <a href="https://chrome.google.com/webstore/detail/web-activity-time-tracker/hhfnghjdeddcfegfekjeihfmbjenlomm/support" target="_blank">support
6969
form</a>.</label>

scripts/activity.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ class Activity {
5454
return hostname;
5555
}
5656

57+
loadDataFromStorage(){
58+
var tabs = storage.load(STORAGE_TABS);
59+
}
60+
5761
updateFavicon(tab){
5862
var domain = this.extractHostname(tab.url);
5963
var currentTab = this.getTab(domain);

scripts/background.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
var tabs = [];
44
var currentTab;
55
var activity = new Activity();
6+
var storage = new LocalStorage();
67

78
var setting_interval_save;
89
var setting_interval_inactivity;
@@ -17,8 +18,8 @@ function updateStorage() {
1718
}
1819

1920
function backgroundCheck() {
20-
storageLocal.getSettings(SETTINGS_INTERVAL_INACTIVITY, function (item) { setting_interval_inactivity = item; });
21-
storageLocal.getSettings(SETTINGS_VIEW_TIME_IN_BADGE, function (item) { setting_view_in_badge = item; });
21+
storage.getSettings(SETTINGS_INTERVAL_INACTIVITY, function (item) { setting_interval_inactivity = item; });
22+
storage.getSettings(SETTINGS_VIEW_TIME_IN_BADGE, function (item) { setting_view_in_badge = item; });
2223
chrome.windows.getLastFocused({ populate: true }, function (currentWindow) {
2324
if (currentWindow.focused) {
2425
var activeTab = currentWindow.tabs.find(t => t.active === true);
@@ -57,14 +58,14 @@ function backgroundCheck() {
5758

5859
function backgroundUpdateStorage() {
5960
if (tabs.length > 0)
60-
storageLocal.saveTabs(tabs);
61+
storage.saveTabs(tabs);
6162
}
6263

6364
function setDefaultSettings() {
64-
storageLocal.saveSettings(SETTINGS_INTERVAL_INACTIVITY, SETTINGS_INTERVAL_INACTIVITY_DEFAULT);
65-
storageLocal.saveSettings(SETTINGS_INTERVAL_RANGE, SETTINGS_INTERVAL_RANGE_DEFAULT);
66-
storageLocal.saveSettings(SETTINGS_VIEW_TIME_IN_BADGE, SETTINGS_VIEW_TIME_IN_BADGE_DEFAULT);
67-
storageLocal.saveSettings(SETTINGS_INTERVAL_SAVE_STORAGE, SETTINGS_INTERVAL_SAVE_STORAGE_DEFAULT);
65+
storage.saveSettings(SETTINGS_INTERVAL_INACTIVITY, SETTINGS_INTERVAL_INACTIVITY_DEFAULT);
66+
storage.saveSettings(SETTINGS_INTERVAL_RANGE, SETTINGS_INTERVAL_RANGE_DEFAULT);
67+
storage.saveSettings(SETTINGS_VIEW_TIME_IN_BADGE, SETTINGS_VIEW_TIME_IN_BADGE_DEFAULT);
68+
storage.saveSettings(SETTINGS_INTERVAL_SAVE_STORAGE, SETTINGS_INTERVAL_SAVE_STORAGE_DEFAULT);
6869
}
6970

7071
function addListener() {

scripts/storage.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var storageLocal = {
3+
class LocalStorage {
44
loadTabs(name, callback) {
55
chrome.storage.sync.get(name, function (item) {
66
if (item[name] !== undefined) {
@@ -9,17 +9,17 @@ var storageLocal = {
99
callback(result);
1010
}
1111
});
12-
},
12+
}
1313

1414
saveTabs(value, callback) {
1515
chrome.storage.sync.set({ tabs: value });
1616
if (callback !== undefined)
1717
callback();
18-
},
18+
}
1919

2020
saveSettings(name, value) {
2121
chrome.storage.sync.set({ [name]: value });
22-
},
22+
}
2323

2424
getSettings(name, callback) {
2525
chrome.storage.sync.get(name, function (item) {
@@ -28,4 +28,4 @@ var storageLocal = {
2828
}
2929
});
3030
}
31-
}
31+
};

scripts/webact.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22

3+
var storage = new LocalStorage();
34
var ui = new UI();
45
var totalTime;
56
var tabsFromStorage;
@@ -9,7 +10,7 @@ var today = new Date().toLocaleDateString();
910
var setting_range_days;
1011

1112
document.addEventListener('DOMContentLoaded', function () {
12-
storageLocal.getSettings(SETTINGS_INTERVAL_RANGE, function (item) { setting_range_days = item; });
13+
storage.getSettings(SETTINGS_INTERVAL_RANGE, function (item) { setting_range_days = item; });
1314
document.getElementById('btnToday').addEventListener('click', function () {
1415
currentTypeOfList = TypeListEnum.ToDay;
1516
ui.setUIForToday();
@@ -42,11 +43,11 @@ function firstInitPage() {
4243
}
4344

4445
function getDataFromStorage() {
45-
storageLocal.loadTabs(STORAGE_TABS, getTabsFromStorage);
46+
storage.loadTabs(STORAGE_TABS, getTabsFromStorage);
4647
}
4748

4849
function getDataFromStorageByDays() {
49-
storageLocal.loadTabs(STORAGE_TABS, getTabsByDays);
50+
storage.loadTabs(STORAGE_TABS, getTabsByDays);
5051
}
5152

5253
function getTabsFromStorage(tabs) {

0 commit comments

Comments
 (0)