Fixed JSHint warnings

Author: fblundun

src/js/forms.js

@@ -77,7 +77,7 @@ object.getFormTrackingManager = function (core, trackerId) {
 	 */
 	function getInnerFormElements(elt) {
 		var innerElements = [];
-		var formElements = lodash.map(innerElementTags, function (tagname) {
+		lodash.map(innerElementTags, function (tagname) {
 			lodash.map(elt.getElementsByTagName(tagname), function (child) {
 				if (child.type === 'submit') {
 					return;
@@ -150,4 +150,4 @@ object.getFormTrackingManager = function (core, trackerId) {
 			});
 		}
 	};
-}
+};

src/js/in_queue.js

@@ -141,7 +141,7 @@
 		 *      [ functionObject, optional_parameters ]
 		 */
 		function applyAsyncFunction() {
-			var i, f, parameterArray, input, parsedString, names, namedTrackers;
+			var i, j, f, parameterArray, input, parsedString, names, namedTrackers;
 
 			// Outer loop in case someone push'es in zarg of arrays
 			for (i = 0; i < arguments.length; i += 1) {
@@ -173,11 +173,11 @@
 				namedTrackers = getNamedTrackers(names);
 
 				if (lodash.isString(f)) {
-					for (var j = 0; j < namedTrackers.length; j++) {
+					for (j = 0; j < namedTrackers.length; j++) {
 						namedTrackers[j][f].apply(namedTrackers[j], parameterArray);
 					}
 				} else {
-					for (var j = 0; j < namedTrackers.length; j++) {
+					for (j = 0; j < namedTrackers.length; j++) {
 						f.apply(namedTrackers[j], parameterArray);
 					}
 				}
@@ -192,6 +192,6 @@
 		return {
 			push: applyAsyncFunction
 		};
-	}
+	};
 
 }());

src/js/links.js

@@ -185,7 +185,7 @@ object.getLinkTrackingManager = function (core, trackerId) {
 			if (lodash.isArray(criterion) || !lodash.isObject(criterion)) {
 				linkTrackingFilter = function (link) {
 					return true;
-				}
+				};
 				return;
 			}
 
@@ -209,7 +209,7 @@ object.getLinkTrackingManager = function (core, trackerId) {
 
 				linkTrackingFilter = function(link) {
 					return checkLink(link, specifiedClassesSet) === inclusive;
-				}
+				};
 			}
 		},
 
@@ -230,4 +230,4 @@ object.getLinkTrackingManager = function (core, trackerId) {
 			}
 		}
 	};
-}
+};

src/js/out_queue.js

@@ -55,7 +55,7 @@
 		}
 
 		// Initialize to and empty array if we didn't get anything out of localStorage
-		if (typeof outQueue === 'undefined' || outQueue == null) {
+		if (!outQueue) {
 			outQueue = [];
 		}
 
@@ -104,18 +104,18 @@
 					localStorage.setItem(queueName, json2.stringify(outQueue));
 				}
 				executeQueue();
-			}
+			};
 
 			image.onerror = function () {
 				executingQueue = false;
-			}
+			};
 
 			image.src = configCollectorUrl + nextRequest;
 		}
 
 		return {
 			enqueueRequest: enqueueRequest
 		};
-	}
+	};
 
 }());

src/js/snowplow.js

@@ -251,6 +251,6 @@
 
 		// Now replace initialization array with queue manager object
 		return new queue.InQueueManager(tracker.Tracker, version, mutSnowplowState, asynchronousQueue, functionName);
-	}
+	};
 
 }());

src/js/tracker.js

@@ -69,7 +69,8 @@
 	 * 7. userFingerprint, true
 	 * 8. userFingerprintSeed, 123412414
 	 * 9. pageUnloadTimer, 500
-	 * 10. writeCookies, true
+	 * 10. forceSecureTracker, false
+	 * 11. writeCookies, true
 	 */
 	object.Tracker = function Tracker(functionName, namespace, version, mutSnowplowState, argmap) {