fix error messages

Author: svenvg93

app/Actions/Notifications/SendAppriseTestNotification.php

@@ -35,19 +35,17 @@ public function handle(array $channel_urls): void
                 FacadesNotification::route('apprise_urls', $channelUrl)
                     ->notifyNow(new TestNotification);
             }
+
+            Notification::make()
+                ->title('Test Apprise notification sent successfully')
+                ->success()
+                ->send();
         } catch (Throwable $e) {
             Notification::make()
                 ->title('Failed to send Apprise test notification')
                 ->body($e->getMessage())
                 ->danger()
                 ->send();
-
-            return;
         }
-
-        Notification::make()
-            ->title('Test Apprise notification sent.')
-            ->success()
-            ->send();
     }
 }

app/Notifications/AppriseChannel.php

@@ -51,13 +51,16 @@ public function send(object $notifiable, Notification $notification): void
             // Execute the apprise command
             $result = Process::timeout(30)->run($command);
 
+            // Combine stdout and stderr as apprise outputs to both
+            $fullOutput = trim($result->output()."\n".$result->errorOutput());
+
             if (! $result->successful()) {
-                throw new Exception('Apprise CLI failed: '.$result->errorOutput());
+                throw new Exception($fullOutput ?: 'Apprise CLI failed with no output');
             }
 
             Log::info('Apprise notification sent', [
                 'channels' => $urls,
-                'output' => $result->output(),
+                'output' => $fullOutput,
             ]);
         } catch (Throwable $e) {
             Log::error('Apprise notification failed', [