From 79e6887ca723f1d926c200127b65612e9e214c40 Mon Sep 17 00:00:00 2001 From: Silviu Tantos Date: Sun, 5 Aug 2018 14:16:48 +0200 Subject: [PATCH 1/2] Do not pin dependencies to specific versions Because the packages in `setup.py` are really old and they use exact version, when installing the package into a virtualenv it will end-up downgrading already existing packages. In the Python documentation it is also mentioned that it is not a best practice to use `install_requires` to pin dependencies to specific versions. See also: - https://github.com/snowplow/snowplow-python-tracker/issues/195 - https://github.com/snowplow/snowplow-python-tracker/issues/198 - https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires --- setup.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index 88392f47..cafd4581 100644 --- a/setup.py +++ b/setup.py @@ -75,12 +75,12 @@ ], install_requires=[ - "greenlet==0.4.10", - "requests==2.2.1", + "greenlet>=0.4.10", + "requests>=2.2.1", "pycontracts==1.7.6", - "celery==3.1.11", - "gevent==1.0.2", - "redis==2.9.1", - "six==1.9.0" + "celery>=3.1.11,<3.1.25", + "gevent>=1.0.2", + "redis>=2.9.1", + "six>=1.9.0" ], ) From 8e522bf86daed315e3f7656ccab04f08e1a4d7c2 Mon Sep 17 00:00:00 2001 From: Silviu Tantos Date: Sun, 5 Aug 2018 14:36:13 +0200 Subject: [PATCH 2/2] Default version of setuptools on Travis is old --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 7424bc4e..4f073aab 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,8 @@ python: - '3.4' - '3.5' install: +# ensure we have recent pip/setuptools +- pip install --upgrade pip setuptools - pip install -r requirements-test.txt - pip install release-manager - pip install -e .