From 71dc85cd65e990e76953033620193a8b700ff097 Mon Sep 17 00:00:00 2001 From: Jack Keene Date: Thu, 6 Jun 2024 06:58:18 +0100 Subject: [PATCH 1/4] expose MediaEventType from media plugin api --- plugins/browser-plugin-media/src/api.ts | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/plugins/browser-plugin-media/src/api.ts b/plugins/browser-plugin-media/src/api.ts index 8ef0bbf91..7ac81e8c1 100644 --- a/plugins/browser-plugin-media/src/api.ts +++ b/plugins/browser-plugin-media/src/api.ts @@ -23,7 +23,7 @@ import { EventWithContext, } from './types'; -export { MediaAdBreakType as MediaPlayerAdBreakType }; +export { MediaAdBreakType as MediaPlayerAdBreakType, MediaEventType }; const _trackers: Record = {}; const _context: Record = {}; @@ -396,7 +396,9 @@ export function trackMediaAdSkip( trackers: Array = Object.keys(_trackers) ) { let { percentProgress } = args; - if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); } + if (percentProgress !== undefined) { + percentProgress = Math.floor(percentProgress); + } track( { mediaEvent: { @@ -506,7 +508,9 @@ export function trackMediaAdClick( trackers: Array = Object.keys(_trackers) ) { let { percentProgress } = args; - if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); } + if (percentProgress !== undefined) { + percentProgress = Math.floor(percentProgress); + } track( { mediaEvent: { @@ -534,7 +538,9 @@ export function trackMediaAdPause( trackers: Array = Object.keys(_trackers) ) { let { percentProgress } = args; - if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); } + if (percentProgress !== undefined) { + percentProgress = Math.floor(percentProgress); + } track( { mediaEvent: { @@ -563,7 +569,9 @@ export function trackMediaAdResume( trackers: Array = Object.keys(_trackers) ) { let { percentProgress } = args; - if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); } + if (percentProgress !== undefined) { + percentProgress = Math.floor(percentProgress); + } track( { mediaEvent: { From ba823d49792b51c97062dfb8eb4709f3b03466ce Mon Sep 17 00:00:00 2001 From: Jack Keene Date: Thu, 6 Jun 2024 06:59:51 +0100 Subject: [PATCH 2/4] rush change --- ...issue-export-media-event-type_2024-06-06-05-59.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 common/changes/@snowplow/browser-plugin-media/issue-export-media-event-type_2024-06-06-05-59.json diff --git a/common/changes/@snowplow/browser-plugin-media/issue-export-media-event-type_2024-06-06-05-59.json b/common/changes/@snowplow/browser-plugin-media/issue-export-media-event-type_2024-06-06-05-59.json new file mode 100644 index 000000000..232694363 --- /dev/null +++ b/common/changes/@snowplow/browser-plugin-media/issue-export-media-event-type_2024-06-06-05-59.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@snowplow/browser-plugin-media", + "comment": "Expose MediaEventType", + "type": "none" + } + ], + "packageName": "@snowplow/browser-plugin-media" +} \ No newline at end of file From 9f592f33ff4c5b5128fdc74466da7285570755bd Mon Sep 17 00:00:00 2001 From: Jack Keene Date: Thu, 6 Jun 2024 07:01:53 +0100 Subject: [PATCH 3/4] rush change --- ...issue-export-media-event-type_2024-06-06-05-59.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 common/changes/@snowplow/browser-tracker/issue-export-media-event-type_2024-06-06-05-59.json diff --git a/common/changes/@snowplow/browser-tracker/issue-export-media-event-type_2024-06-06-05-59.json b/common/changes/@snowplow/browser-tracker/issue-export-media-event-type_2024-06-06-05-59.json new file mode 100644 index 000000000..adcc4e624 --- /dev/null +++ b/common/changes/@snowplow/browser-tracker/issue-export-media-event-type_2024-06-06-05-59.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@snowplow/browser-tracker", + "comment": "Expose MediaEventType", + "type": "none" + } + ], + "packageName": "@snowplow/browser-tracker" +} \ No newline at end of file From 1a4c7cc9bd35d1ea3e3dbbdc9db10e5bb4f0a9fb Mon Sep 17 00:00:00 2001 From: Jack Keene Date: Thu, 6 Jun 2024 07:03:10 +0100 Subject: [PATCH 4/4] formatting