From b1d72d3eadac553f1c7dc0af787b441a12c7b848 Mon Sep 17 00:00:00 2001 From: Chris Sherlock Date: Thu, 19 Oct 2017 10:59:55 +1100 Subject: [PATCH 1/2] warn if usePost is undefined (close #613) --- src/js/out_queue.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/js/out_queue.js b/src/js/out_queue.js index 33b28bea1..2bcde2ca8 100644 --- a/src/js/out_queue.js +++ b/src/js/out_queue.js @@ -62,7 +62,16 @@ outQueue; // Fall back to GET for browsers which don't support CORS XMLHttpRequests (e.g. IE <= 9) - usePost = usePost && window.XMLHttpRequest && ('withCredentials' in new XMLHttpRequest()); + if (typeof usePost != 'undefined') + { + usePost = usePost && window.XMLHttpRequest && ('withCredentials' in new XMLHttpRequest()); + path = usePost ? '/com.snowplowanalytics.snowplow/tp2' : '/i'; + } + else + { + Console.warn('usePost undefined'); + path = '/i'; + } var path = usePost ? '/com.snowplowanalytics.snowplow/tp2' : '/i'; From 947f71e70cd84fa47fff435662ed9af0ac32be31 Mon Sep 17 00:00:00 2001 From: Chris Sherlock Date: Thu, 19 Oct 2017 19:41:20 +1100 Subject: [PATCH 2/2] update Tracker documentation (close: #605) --- src/js/tracker.js | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/src/js/tracker.js b/src/js/tracker.js index 955626225..5df7e5dbe 100755 --- a/src/js/tracker.js +++ b/src/js/tracker.js @@ -66,23 +66,21 @@ * 4. appId, '' * 5. platform, 'web' * 6. respectDoNotTrack, false - * 7. userFingerprint, true - * 8. userFingerprintSeed, 123412414 - * 9. pageUnloadTimer, 500 - * 10. forceSecureTracker, false - * 11. forceUnsecureTracker, false - * 12. useLocalStorage, true - * 13. useCookies, true - * 14. sessionCookieTimeout, 1800 - * 15. contexts, {} - * 16. post, false - * 17. bufferSize, 1 - * 18. crossDomainLinker, false - * 19. maxPostBytes, 40000 - * 20. discoverRootDomain, false - * 21. cookieLifetime, 63072000 - * 22. stateStorageStrategy, 'cookieAndLocalStorage' - * 23. respectOptOutCookie, false + * 7. userFingerprintSeed, 123412414 + * 8. pageUnloadTimer, 500 + * 9. forceSecureTracker, false + * 10. forceUnsecureTracker, false + * 11. useLocalStorage, true + * 12. useCookies, true + * 13. sessionCookieTimeout, 1800 + * 14. contexts, {} + * 15. post, false + * 16. bufferSize, 1 + * 17. crossDomainLinker, false + * 18. maxPostBytes, 40000 + * 19. discoverRootDomain, false + * 20. cookieLifetime, 63072000 + * 21. stateStorageStrategy, 'cookieAndLocalStorage' */ object.Tracker = function Tracker(functionName, namespace, version, mutSnowplowState, argmap) {