Fixing ResolutionManager after finding while loop bug

Author: omundy

Assets/_Project/Scenes/tally-viz.unity

@@ -10,8 +10,7 @@
  *  Manage game "resolution" - runs in play mode AND editor
  */
 
-
-//[ExecuteAlways]
+[ExecuteAlways]
 public class ResolutionManager : MonoBehaviour {
 
 
@@ -32,9 +31,6 @@ public class ResolutionManager : MonoBehaviour {
 
 
 
-
-
-
     [Space (10)]
     [Header ("UNITY PLAYER")]
     // states of the Unity 'player' or 'game view' window
@@ -44,9 +40,9 @@ public class ResolutionManager : MonoBehaviour {
     // - unfortunately named using "Screen" https://docs.unity3d.com/ScriptReference/Screen-height.html
     public Vector2 playerResolution;
 
-    [Tooltip ("Resolution of the game view")]
-    // - set in Unity, stored in Application Support (Mac) (may be same as above)
-    public Vector2 gameViewResolution;
+    //[Tooltip ("Resolution of the game view")]
+    //// - set in Unity, stored in Application Support (Mac) (seems to always be same as above)
+    //public Vector2 gameViewResolution;
 
     [Tooltip ("The size of the player view (we will set) in unity units")]
     // depends on camera size
@@ -62,7 +58,6 @@ public class ResolutionManager : MonoBehaviour {
 
 
 
-
     [Space (10)]
     [Header ("----- DEVICE -----")]
     // states of the screen / device display
@@ -80,122 +75,63 @@ public class ResolutionManager : MonoBehaviour {
 
 
 
-    // OBJECTS TO UPDATE WHEN ABOVE PARAMETERS CHANGE
+    // OBJECTS - UPDATE IF PARAMETERS CHANGE
 
     [Space (10)]
-    [Header ("OBJECTS REFERENCES")]
-
-
+    [Header ("OBJECT REFERENCES")]
 
     [Tooltip ("Collider that defines the volume of the visible game world")]
     public BoxCollider worldContainerCollider;
-
     public TMP_Text resolutionReportText;
 
 
 
 
 
-    //[SerializeField]
-    //private int framesSinceSizeUpdated = 0;
-
-    //bool updateWorld = true;
-
-
     private void Awake ()
     {
-
         // for some reason using the collider on this object caused the editor to crash every time
         worldContainerCollider = GetComponent<BoxCollider> ();
-        // this is the other one
-        //worldContainerCollider = GameObject.Find ("WorldContainer").GetComponent<BoxCollider> ();
 
-        UpdateResolutionParams ();
+        StartCoroutine (SendResolutionUpdatedEvent ());
     }
 
+
     private void Update ()
     {
-        // if application is playing 
-        if (Application.IsPlaying (gameObject)) {
-            // and if player resolution has changed
-            if (playerResolution.x != Screen.width || playerResolution.y != Screen.height) {
-                // update the parameters
-                UpdateResolutionParams ();
-                // update collider
-                UpdateColliderSize ();
 
+        // and if player resolution has changed
+        if (playerResolution.x != Screen.width || playerResolution.y != Screen.height) {
+            //Debug.Log ("ResolutionManager.Update() - resolution has changed to " + playerResolution.ToString ());
 
-                // trigger data updated event
-                EventManager.TriggerEvent ("ResolutionUpdated");
-
-            }
+            StartCoroutine (SendResolutionUpdatedEvent ());
         }
+    }
 
+    IEnumerator SendResolutionUpdatedEvent ()
+    {
+        Debug.Log ("ResolutionManager.SendResolutionUpdatedEvent() - resolution has changed to " + playerResolution.ToString ());
 
+        // update the parameters
+        UpdateResolutionParams ();
 
+        // update collider
+        UpdateColliderSize ();
 
-        //if (Application.IsPlaying (gameObject)) {
-
-
-
-        //    // if player resolution has changed
-        //    if (playerResolution.x != Screen.width || playerResolution.y != Screen.height) {
-        //        // update the parameters
-        //        UpdateResolutionParams ();
-        //        //// reset counter
-        //        //framesSinceSizeUpdated++;
-
-        //        updateWorld = true;
-        //    }
-
-
-
-
-
-        //    //if (framesSinceSizeUpdated > 0) framesSinceSizeUpdated++;
-
-        //    //// wait a second after a resolution update
-        //    //if (framesSinceSizeUpdated > 10) {
-        //    //    updateWorld = true;
-        //    //}
-
-
-        //}
-
-
-
-
-
-
-        //if (updateWorld) {
-        //    UpdateReport ();
-        //    UpdateColliderSize ();
+        UpdateReport ();
 
+        yield return new WaitForSeconds (.2f);
 
-        //    // reset counter
-        //    framesSinceSizeUpdated = 0;
-        //}
 
+        // if application is playing 
+        if (Application.IsPlaying (gameObject)) {
 
-        //// reset
-        //updateWorld = false;
+            // trigger data updated event
+            EventManager.TriggerEvent ("ResolutionUpdated");
+        }
     }
 
 
-    void UpdateColliderSize ()
-    {
-        // make sure there isn't a negative number
-        if (playerViewSize.x > 0 && playerViewSize.y > 0) {
-            worldContainerCollider.size = new Vector3 (playerViewSize.x, playerViewSize.y, worldContainerCollider.size.z);
-
-
-            // debugging
-            Debug.Log ("ResolutionManager.UpdateColliderSize() playerViewSize = " + playerViewSize.ToString ());
-            Debug.Log ("ResolutionManager.UpdateColliderSize() worldContainerCollider.size = " + worldContainerCollider.size.ToString ());
-            Debug.Log ("ResolutionManager.UpdateColliderSize() worldContainerCollider.bounds = " + worldContainerCollider.bounds.ToString ());
-        }
-
-    }
 
     /**
      *  Update all the resolution parameters
@@ -204,13 +140,14 @@ public void UpdateResolutionParams ()
     {
         //Debug.Log ("ResolutionManager.UpdateResolutionParams()");
 
+
         // CAMERA / CANVAS
         cameraSize = Camera.main.orthographicSize;
         canvasResolution = new Vector2 (canvasRect.sizeDelta.x, canvasRect.sizeDelta.y);
 
         // PLAYER PARAMS
         playerResolution = new Vector2 (Screen.width, Screen.height);
-        gameViewResolution = GetMainGameViewSize ();
+        //gameViewResolution = GetMainGameViewSize ();
         playerViewSize = GetPlayerViewSize ();
         playerAspectRatio = playerResolution.x / playerResolution.y;
         playerFullScreen = Screen.fullScreen;
@@ -220,11 +157,45 @@ public void UpdateResolutionParams ()
         deviceAspectRatio = deviceResolution.x / deviceResolution.y;
     }
 
+    /**
+     *  Update the text in the UI
+     */
+    void UpdateReport ()
+    {
+        // update text in control panel
+        string report =
+            //"canvasResolution (px): " + canvasResolution.ToString () + "\n" + 
+            "playerResolution (px): " + playerResolution.ToString () + "\n" +
+            //"gameViewResolution (px): " + gameViewResolution.ToString () +
+            "playerViewSize (units): " + playerViewSize.ToString () + "\n" +
+            "playerAspectRatio: " + playerAspectRatio.ToString () + "\n" +
+            "playerFullScreen: " + playerFullScreen.ToString () + "\n" +
+            "deviceResolution: " + deviceResolution.ToString ();
+        resolutionReportText.text = report;
+    }
+
+    void UpdateColliderSize ()
+    {
+        //Debug.Log ("ResolutionManager.UpdateColliderSize() [1]");
+
+        if (playerViewSize.x > 0 && playerViewSize.y > 0) {
+            // set new size, making sure there isn't a negative number
+            worldContainerCollider.size = new Vector3 (playerViewSize.x, playerViewSize.y, worldContainerCollider.size.z);
+
+            //Debug.Log ("ResolutionManager.UpdateColliderSize() [2]");
+        }
+        //Debug.Log ("ResolutionManager.UpdateColliderSize() playerViewSize = " + playerViewSize.ToString ());
+        //Debug.Log ("ResolutionManager.UpdateColliderSize() worldContainerCollider.size = " + worldContainerCollider.size.ToString ());
+        //Debug.Log ("ResolutionManager.UpdateColliderSize() worldContainerCollider.bounds = " + worldContainerCollider.bounds.ToString ());
+    }
+
     /**
      *  Return the player viewing volume size (in Unity units)
      */
     public static Vector3 GetPlayerViewSize ()
     {
+        //Debug.Log ("ResolutionManager.GetPlayerViewSize()");
+
         // The orthographicSize is half of the vertical viewing volume size
         float height = Camera.main.orthographicSize * 2;
         // The horizontal size of the viewing volume depends on the aspect ratio so...
@@ -237,7 +208,7 @@ public static Vector3 GetPlayerViewSize ()
     /**
      *  Return the editor Game View window size - works in editor
      */
-    public static Vector2 GetMainGameViewSize ()
+    static Vector2 GetMainGameViewSize ()
     {
         System.Type T = System.Type.GetType ("UnityEditor.GameView,UnityEditor");
         System.Reflection.MethodInfo GetSizeOfMainGameView = T.GetMethod ("GetSizeOfMainGameView", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Static);
@@ -246,22 +217,8 @@ public static Vector2 GetMainGameViewSize ()
     }
 
 
-    /**
-     *  Update the text in the UI
-     */
-    void UpdateReport ()
-    {
-        // update text in control panel
-        string report =
-            "playerResolution: " + playerResolution.ToString () +
-            "\n" + "gameViewResolution: " + gameViewResolution.ToString () +
-            "\n" + "playerViewSize: " + playerViewSize.ToString () +
-            "\n" + "playerAspectRatio: " + playerAspectRatio.ToString () +
-            "\n" + "playerFullScreen: " + playerFullScreen.ToString () +
-            "\n" + "deviceResolution: " + deviceResolution.ToString () +
-            "\n" + "deviceResolution: " + deviceResolution.ToString ();
-        resolutionReportText.text = report;
-    }
+
+
 
 
 

Assets/_Project/Scripts/Core/ResolutionManager.cs

@@ -23,23 +23,15 @@ protected override void Awake ()
     {
         base.Awake ();
 
-        // hide markers
-        if (!showMarkers) {
-            for (int i = 0; i < resolutionMarkers.Length; i++) {
-                resolutionMarkers [i].GetComponent<SpriteRenderer> ().enabled = false;
-            }
-            return;
-        }
+
 
         // set original scale (after everything is computer) based on startup aspect ratio
         UpdateResolution ();
     }
 
     protected override void UpdateResolution ()
     {
-        base.UpdateResolution ();
-
-        if (!showMarkers) return;
+        //base.UpdateResolution ();
 
         // update marker positions
         UpdateMarkerPositions ();
@@ -49,7 +41,15 @@ protected override void UpdateResolution ()
 
     void UpdateMarkerPositions ()
     {
-        //Debug.Log ("UpdateGameObjectPositions()");
+        //Debug.Log ("UpdateMarkerPositions()");
+
+        // hide markers
+        if (showMarkers != DebugManager.status) {
+            showMarkers = DebugManager.status;
+            for (int i = 0; i < resolutionMarkers.Length; i++) {
+                resolutionMarkers [i].GetComponent<SpriteRenderer> ().enabled = showMarkers;
+            }
+        }
 
         // display the nine point grid
         ninePointGrid = GetPlanePointGrid (resolutionManager.worldContainerCollider.bounds);