Add locale feedback link if not zh-CN (#90)

Author: sheepzh

src/app/layout/menu.ts

@@ -10,11 +10,10 @@ import { ElIcon, ElMenu, ElMenuItem, ElMenuItemGroup, MenuItemRegistered } from
 import { RouteLocationNormalizedLoaded, Router, useRoute, useRouter } from "vue-router"
 import { I18nKey, t } from "@app/locale"
 import { MenuMessage } from "@app/locale/components/menu"
-import { GITHUB_ISSUE_ADD, HOME_PAGE, MEAT_URL, TU_CAO_PAGE } from "@util/constant/url"
+import { HOME_PAGE, MEAT_URL, TU_CAO_PAGE } from "@util/constant/url"
 import { Aim, Calendar, ChatSquare, Folder, Food, HotWater, Rank, SetUp, Stopwatch, Sugar, Tickets, Timer } from "@element-plus/icons-vue"
 import ElementIcon from "../element-ui/icon"
 import { locale } from "@util/i18n"
-import { IS_EDGE } from "@util/constant/environment"
 
 type _MenuItem = {
     title: keyof MenuMessage
@@ -35,37 +34,46 @@ type _RouteProps = {
 }
 
 /**
- * Use TU_CAO_PAGE, if the locale is Chinese
- * 
- * @since 0.9.0
+ * Generate menu items after locale initialized
  */
-let realFeedbackLink: string = GITHUB_ISSUE_ADD
-if (locale === 'zh_CN') {
-    realFeedbackLink = TU_CAO_PAGE
-}
-
-const OTHER_MENU_ITEMS: _MenuItem[] = [{
-    title: 'feedback',
-    href: realFeedbackLink,
-    icon: ChatSquare,
-    index: '_feedback'
-}]
-HOME_PAGE && OTHER_MENU_ITEMS.push({
-    title: 'rate',
-    href: HOME_PAGE,
-    icon: Sugar,
-    index: '_rate'
-})
-OTHER_MENU_ITEMS.push({
-    title: 'meat',
-    href: MEAT_URL,
-    icon: Food,
-    index: '_meat'
-})
+function generateMenus(): _MenuGroup[] {
+    /**
+     * Use TU_CAO_PAGE, if the locale is Chinese
+     * 
+     * @since 0.9.0
+     */
+    const isZhCn = locale === "zh_CN"
+
+    const otherMenuItems: _MenuItem[] = []
+    HOME_PAGE && otherMenuItems.push({
+        title: 'rate',
+        href: HOME_PAGE,
+        icon: Sugar,
+        index: '_rate'
+    })
+    if (isZhCn) {
+        otherMenuItems.push({
+            title: 'feedback',
+            href: TU_CAO_PAGE,
+            icon: ChatSquare,
+            index: '_feedback'
+        }, {
+            title: 'meat',
+            href: MEAT_URL,
+            icon: Food,
+            index: '_meat'
+        })
+    } else {
+        otherMenuItems.push({
+            title: 'translationMistake',
+            href: 'https://github.com/sheepzh/timer/issues/new?assignees=&labels=locale&template=translation-------.md&title=Report+translation+mistakes',
+            icon: ChatSquare,
+            index: '_i18n'
+        })
+    }
 
-// All menu items
-const ALL_MENU: _MenuGroup[] = [
-    {
+    // All menu items
+    return [{
         title: 'data',
         children: [{
             title: 'dataReport',
@@ -112,9 +120,9 @@ const ALL_MENU: _MenuGroup[] = [
         }]
     }, {
         title: 'other',
-        children: OTHER_MENU_ITEMS
-    }
-]
+        children: otherMenuItems
+    }]
+}
 
 function openMenu(route: string, title: I18nKey, routeProps: UnwrapRef<_RouteProps>) {
     const routerVal = routeProps.router
@@ -175,7 +183,7 @@ const _default = defineComponent({
 
         return () => h(ElMenu,
             { defaultActive: routeProps.current.path },
-            () => ALL_MENU.map(menu => renderMenu(menu, routeProps))
+            () => generateMenus().map(menu => renderMenu(menu, routeProps))
         )
     }
 })

src/app/locale/components/menu.ts

@@ -24,6 +24,7 @@ export type MenuMessage = {
     feedback: string
     rate: string
     meat: string
+    translationMistake: string
 }
 const _default: Messages<MenuMessage> = {
     zh_CN: {
@@ -42,7 +43,8 @@ const _default: Messages<MenuMessage> = {
         other: '其他',
         feedback: '有什么反馈吗？',
         rate: '打个分吧！',
-        meat: '请作者吃饭~'
+        meat: '请作者吃饭~',
+        translationMistake: '提交翻译错误'
     },
     zh_TW: {
         data: '我的數據',
@@ -60,7 +62,8 @@ const _default: Messages<MenuMessage> = {
         other: '其他',
         feedback: '有什麼反饋嗎？',
         rate: '打個分吧！',
-        meat: '請作者吃飯~'
+        meat: '請作者吃飯~',
+        translationMistake: '改善翻译~'
     },
     en: {
         data: 'My Data',
@@ -78,7 +81,8 @@ const _default: Messages<MenuMessage> = {
         option: 'Options',
         feedback: 'Feedback',
         rate: 'Rate It',
-        meat: 'Invite the author to dinner'
+        meat: 'Invite the author to dinner',
+        translationMistake: 'Improve translation'
     },
     ja: {
         data: '私のデータ',
@@ -96,7 +100,8 @@ const _default: Messages<MenuMessage> = {
         option: '拡張設定',
         feedback: 'フィードバック',
         rate: 'それを評価',
-        meat: '著者を夕食に招待する'
+        meat: '著者を夕食に招待する',
+        translationMistake: '翻訳を改善する'
     }
 }