Fix find() with anydbm. Add fast return shortcut.

Using protected properties raised KeyError.  Add shortcut fast
return. Both changes come from rdbms_common.py's find(). Add test
case.

Author: rouilj

CHANGES.txt

@@ -122,6 +122,9 @@ Fixed:
 - issue2550964 - History can (temporarily) show incorrect value when a
   change is rejected. Fix history function to always use the database
   values and ignore the current setting in the form.
+- Fix find() with anydbm. Using protected properties raised KeyError.
+  Add shortcut fast return. Both changes come from rdbms_common.py's
+  find(). (John Rouillard)
 
 Features:
 - issue2550522 - Add 'filter' command to command-line

roundup/backends/back_anydbm.py

@@ -1506,9 +1506,15 @@ def find(self, **propspec):
             db.issue.find(messages=('1','3'), files=('7',))
             db.issue.find(messages=['1','3'], files=['7'])
         """
+        # shortcut
+        if not propspec:
+            return []
+
+        # validate the args
+        props = self.getprops()
         for propname, itemids in propspec.items():
             # check the prop is OK
-            prop = self.properties[propname]
+            prop = props[propname]
             if not isinstance(prop, hyperdb.Link) and not isinstance(prop, hyperdb.Multilink):
                 raise TypeError("'%s' not a Link/Multilink "
                     "property"%propname)
@@ -1537,7 +1543,7 @@ def find(self, **propspec):
                         continue
 
                     # grab the property definition and its value on this item
-                    prop = self.properties[propname]
+                    prop = props[propname]
                     value = item[propname]
                     if isinstance(prop, hyperdb.Link) and value in itemids:
                         l.append(id)

test/db_test_base.py

@@ -1578,6 +1578,12 @@ def testFindLink(self):
         got.sort()
         self.assertEqual(got, [one, three])
 
+    def testFindProtectedLink(self):
+        one, two, three, four = self._find_test_setup()
+        got = self.db.issue.find(creator='1')
+        got.sort()
+        self.assertEqual(got, [one, two, three, four])
+
     def testFindRevLinkMultilink(self):
         ae, dummy = self.filteringSetupTransitiveSearch('user')
         ni = 'nosy_issues'