Skip to content

Commit fa26b6d

Browse files
committed
fix: update updating.txt doc for user_src_input bug
I originally thought it was not worth documenting because the error case had no impact. But deployed copies of the trackers can be updated to reduce differences between deployed and distributed files.
1 parent 1fa42d5 commit fa26b6d

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

CHANGES.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ Fixed:
3131
command line always worked. (John Rouillard)
3232
- enhanced error reporting for errors in ini style logging
3333
configuration. (John Rouillard)
34-
34+
- fix bogus javascript emitted by user_src_input macro. (John
35+
Rouillard)
36+
3537
Features:
3638

3739
- add support for authorized changes. User can be prompted to enter

doc/upgrading.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,26 @@ stripped before being processed by the logging system.
177177

178178
You can read about the details in the :ref:`admin manual <dictLogConfig>`.
179179

180+
Fix user.item.html template producing invalid Javascript (optional)
181+
-------------------------------------------------------------------
182+
183+
The html template ``page.html`` in the classic, devel, minimal, and
184+
responsive tracker templates define a ``user_src_input`` macro. This
185+
macro produces invalid javascript for the ``onblur`` event when used
186+
by ``user.item.html``. The only effect from this bug is a javascript
187+
error reported in the user's browser when the user does not have edit
188+
permissions on the page. It doesn't have any user visible impact.
189+
190+
If you want to fix this, replace::
191+
192+
tal:attributes="onblur python:edit_ok and 'split_name(this)';
193+
194+
with::
195+
196+
tal:attributes="onblur python:'split_name(this)' if edit_ok else '';
197+
198+
in the ``html/page.html`` file in your tracker.
199+
180200
.. index:: Upgrading; 2.4.0 to 2.5.0
181201

182202
Migrating from 2.4.0 to 2.5.0

0 commit comments

Comments
 (0)