Skip to content

Commit f582053

Browse files
committed
jinja2: show grouping in output, select options in sort control
1 parent e0b1018 commit f582053

File tree

2 files changed

+29
-13
lines changed

2 files changed

+29
-13
lines changed

share/roundup/templates/jinja2/html/issue.index.html

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,18 @@
4646
{% endif %}
4747
</tr>
4848
{% for issue in batch %}
49+
{% if request.group|length %}
50+
{% set group = [request.group[0][1], request.group[1][1]] if request.group|length >= 2 else [request.group[0][1]] %}
51+
{% if batch.propchanged(*group) %}
52+
<tr>
53+
<th class="text-center" colspan="{{ request.columns|length }}">
54+
{%- for g in group -%}
55+
{%- if issue[g] %} {{ issue[g]|u }} {% else %} (no {{ g }} set) {% endif -%}
56+
{%- endfor -%}
57+
</th>
58+
</tr>
59+
{% endif %}
60+
{% endif %}
4961
<tr>
5062
{% if request.show.priority %}
5163
<td>{{ issue.priority.plain()|u }}</td>
Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,59 @@
11
<hr>
2-
<form method="GET" action='{{ request.classname }}'>
3-
<div class='form-group row'>
2+
<form method="GET" action="{{ request.classname }}">
3+
<div class="form-group row">
44
<div class="col-2 text-right">
55
{% trans %}Sort on{% endtrans %}
66
</div>
77
<fieldset class="form-group">
88
{% for i in range(2) %}
9+
{% set key = request.sort[i] if request.sort|length > i else (None, None) %}
910
<div class="row">
10-
<div class='col-auto'>
11-
<select class="custom-select" name='@sort{{i}}'>
11+
<div class="col-auto">
12+
<select class="custom-select" name="@sort{{i}}">
13+
<option value="">{% trans %}- nothing -{% endtrans %}</option>
1214
{% for prop in context.properties() %}
13-
<option value='{{ prop._name }}'>{{ prop._name }}</option>
15+
<option value="{{ prop._name }}" {% if prop._name == key[1] %}selected{% endif %}>{{ prop._name }}</option>
1416
{% endfor %}
1517
</select>
1618
</div>
1719
<div class="col-auto">
1820
<div class="custom-control custom-checkbox my-1 mr-sm-2">
19-
<input type="checkbox" class="custom-control-input" name='@sortdir{{i}}' id='@sortdir{{i}}'>
21+
<input type="checkbox" class="custom-control-input" name="@sortdir{{ i }}" id="@sortdir{{ i }}" {% if key[0] == '-' %}checked{% endif %}>
2022
<label class="custom-control-label" for="@sortdir{{i}}">Descending</label>
2123
</div>
2224
</div>
2325
</div>
2426
{% endfor %}
2527
</fieldset>
2628
</div>
27-
<div class='form-group row'>
29+
<div class="form-group row">
2830
<div class="col-2 text-right">
2931
{% trans %}Group on{% endtrans %}
3032
</div>
3133
<fieldset class="form-group">
3234
{% for i in range(2) %}
35+
{% set key = request.group[i] if request.group|length > i else (None, None) %}
3336
<div class="row">
34-
<div class='col-auto'>
35-
<select class="custom-select" name='@group{{i}}'>
37+
<div class="col-auto">
38+
<select class="custom-select" name="@group{{i}}">
39+
<option value="">{% trans %}- nothing -{% endtrans %}</option>
3640
{%- for prop in context.properties() %}
37-
<option value='{{ prop._name }}'>{{ prop._name }}</option>
41+
<option value="{{ prop._name }}" {% if prop._name == key[1] %}selected{% endif %}>{{ prop._name }}</option>
3842
{%- endfor %}
3943
</select>
4044
</div>
4145
<div class="col-auto">
4246
<div class="custom-control custom-checkbox my-1 mr-sm-2">
43-
<input type="checkbox" class="custom-control-input" name='@groupdir{{i}}' id='@groupdir{{i}}'>
47+
<input type="checkbox" class="custom-control-input" name="@groupdir{{ i }}" id="@groupdir{{ i }}" {% if key[0] == '-' %}checked{% endif %}>
4448
<label class="custom-control-label" for="@groupdir{{i}}">Descending</label>
4549
</div>
4650
</div>
4751
</div>
4852
{% endfor %}
4953
</fieldset>
5054
</div>
51-
<div class='form-actions'>
52-
<input type='submit' value='{% trans %}Redisplay{% endtrans %}' class='btn btn-primary'>
55+
<div class="form-actions">
56+
<input class="btn btn-primary" type="submit" value="{% trans %}Redisplay{% endtrans %}">
5357
{{ request.indexargs_form(sort=0, group=0)|u|safe }}
5458
</div>
5559
</form>

0 commit comments

Comments
 (0)