Indexing fixes.

- Add new rdbms-indexes to the tables for the full-text index. These
  speed up adding new entries and finding old ones to remove.
- Remove getprops method from FileClass in backends/rdbms_common: This
  forced indexing for the content property even if the user decided to
  turn it off for a FileClass instance.

Author: Ralf Schlatterbeck

CHANGES.txt

@@ -17,7 +17,10 @@ Fixed:
 - Fix handling of defaults for date fields
 - Fix <form> name in user editing to allow multilink popups to work
 - Fix form handling of editing existing hyperdb items from a new item page.
-
+- Added new rdbms-indexes for full-text index which will speed up
+  reindexing.
+- Turning off indexing for content properties of FileClass instance
+  (e.g., "file" and "msg") now works for SQL backends.
 
 2007-02-15 1.3.3
 Fixed:

doc/upgrading.txt

@@ -32,6 +32,14 @@ update the messagesummary detector as follows::
     +    summary, content = parseContent(newvalues['content'], config=db.config)
 	 newvalues['summary'] = summary
 
+In the latest version we have added some database indexes to the
+SQL-backends (mysql, postgresql, sqlite) for speeding up building the
+roundup-index for full-text search. We recommend that you create the
+following database indexes on the database by hand::
+
+ CREATE INDEX words_by_id ON __words (_textid)
+ CREATE UNIQUE INDEX __textids_by_props ON __textids (_class, _itemid, _prop)
+
 Migrating from 1.2.x to 1.3.0
 =============================
 

roundup/backends/back_mysql.py

@@ -1,4 +1,4 @@
-#$Id: back_mysql.py,v 1.71 2006-08-29 04:20:50 richard Exp $
+#$Id: back_mysql.py,v 1.72 2007-06-21 07:35:50 schlatterbeck Exp $
 #
 # Copyright (c) 2003 Martynas Sklyzmantas, Andrey Lebedev <[email protected]>
 #
@@ -211,6 +211,9 @@ def create_version_2_tables(self):
         self.sql('''CREATE TABLE __words (_word VARCHAR(30),
             _textid INT) TYPE=%s'''%self.mysql_backend)
         self.sql('CREATE INDEX words_word_ids ON __words(_word)')
+        self.sql('CREATE INDEX words_by_id ON __words (_textid)')
+        self.sql('CREATE UNIQUE INDEX __textids_by_props ON '
+                 '__textids (_class, _itemid, _prop)')
         sql = 'insert into ids (name, num) values (%s,%s)'%(self.arg, self.arg)
         self.sql(sql, ('__textids', 1))
 

roundup/backends/back_postgresql.py

@@ -1,4 +1,4 @@
-#$Id: back_postgresql.py,v 1.37 2006-11-09 00:55:33 richard Exp $
+#$Id: back_postgresql.py,v 1.38 2007-06-21 07:35:50 schlatterbeck Exp $
 #
 # Copyright (c) 2003 Martynas Sklyzmantas, Andrey Lebedev <[email protected]>
 #
@@ -161,6 +161,9 @@ def create_version_2_tables(self):
         self.sql('''CREATE TABLE __words (_word VARCHAR(30), 
             _textid integer)''')
         self.sql('CREATE INDEX words_word_idx ON __words(_word)')
+        self.sql('CREATE INDEX words_by_id ON __words (_textid)')
+        self.sql('CREATE UNIQUE INDEX __textids_by_props ON '
+                 '__textids (_class, _itemid, _prop)')
 
     def fix_version_2_tables(self):
         # Convert journal date column to TIMESTAMP, params column to TEXT

roundup/backends/back_sqlite.py

@@ -1,4 +1,4 @@
-# $Id: back_sqlite.py,v 1.50 2006-12-19 03:01:37 richard Exp $
+# $Id: back_sqlite.py,v 1.51 2007-06-21 07:35:50 schlatterbeck Exp $
 '''Implements a backend for SQLite.
 
 See https://pysqlite.sourceforge.net/ for pysqlite info
@@ -144,6 +144,9 @@ def create_version_2_tables(self):
         self.sql('CREATE TABLE __words (_word varchar, '
             '_textid integer)')
         self.sql('CREATE INDEX words_word_ids ON __words(_word)')
+        self.sql('CREATE INDEX words_by_id ON __words (_textid)')
+        self.sql('CREATE UNIQUE INDEX __textids_by_props ON '
+                 '__textids (_class, _itemid, _prop)')
         sql = 'insert into ids (name, num) values (%s,%s)'%(self.arg, self.arg)
         self.sql(sql, ('__textids', 1))
 

roundup/backends/rdbms_common.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-#$Id: rdbms_common.py,v 1.185 2007-04-11 20:04:06 forsberg Exp $
+#$Id: rdbms_common.py,v 1.186 2007-06-21 07:35:50 schlatterbeck Exp $
 """ Relational database (SQL) backend common code.
 
 Basics:
@@ -2627,18 +2627,6 @@ def get(self, nodeid, propname, default=_marker, cache=1):
         else:
             return Class.get(self, nodeid, propname)
 
-    def getprops(self, protected=1):
-        """In addition to the actual properties on the node, these methods
-        provide the "content" property. If the "protected" flag is true,
-        we include protected properties - those which may not be
-        modified.
-
-        Note that the content prop is indexed separately, hence no indexme.
-        """
-        d = Class.getprops(self, protected=protected).copy()
-        d['content'] = hyperdb.String(indexme='yes')
-        return d
-
     def set(self, itemid, **propvalues):
         """ Snarf the "content" propvalue and update it in a file
         """