Skip to content

Commit f3e007e

Browse files
committed
Sort accept keys to make p2 and p3 ordering the same
Sort keys of self.__accepted_content_type. Keys returned in different orders in python2/3. Sorting makes testing easier.
1 parent 838050c commit f3e007e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

roundup/rest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1987,7 +1987,7 @@ def dispatch(self, method, uri, input):
19871987
self.client.response_code = 406
19881988
output = ( "Requested content type '%s' is not available.\n"
19891989
"Acceptable types: %s"%(data_type,
1990-
", ".join(self.__accepted_content_type.keys())))
1990+
", ".join(sorted(self.__accepted_content_type.keys()))))
19911991

19921992
# Make output json end in a newline to
19931993
# separate from following text in logs etc..

test/rest_common.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1588,7 +1588,7 @@ def testDispatch(self):
15881588

15891589
response="Requested content type 'jon' is not available.\n" \
15901590
"Acceptable types: */*, application/json%s\n"%includexml
1591-
self.assertEqual(results, response)
1591+
self.assertEqual(b2s(results), response)
15921592

15931593
# TEST #9
15941594
# GET: test that version can be set with accept:
@@ -1607,7 +1607,7 @@ def testDispatch(self):
16071607
self.server.client.request.headers.get=self.get_header
16081608
results = self.server.dispatch('GET',
16091609
"/rest/data/issue/1", form)
1610-
print("9a: " + results)
1610+
print("9a: " + b2s(results))
16111611
json_dict = json.loads(b2s(results))
16121612
self.assertEqual(json_dict['error']['status'], 400)
16131613
self.assertEqual(json_dict['error']['msg'],
@@ -1619,7 +1619,7 @@ def testDispatch(self):
16191619
self.server.client.request.headers.get=self.get_header
16201620
results = self.server.dispatch('GET',
16211621
"/rest/data/issue/1", form)
1622-
print("9b: " + results)
1622+
print("9b: " + b2s(results))
16231623
json_dict = json.loads(b2s(results))
16241624
self.assertEqual(json_dict['error']['status'], 400)
16251625
self.assertEqual(json_dict['error']['msg'],
@@ -1631,7 +1631,7 @@ def testDispatch(self):
16311631
self.server.client.request.headers.get=self.get_header
16321632
results = self.server.dispatch('GET',
16331633
"/rest/data/issue/1", self.empty_form)
1634-
print("9c:" + results)
1634+
print("9c:" + b2s(results))
16351635
self.assertEqual(self.server.client.response_code, 400)
16361636
json_dict = json.loads(b2s(results))
16371637
self.assertEqual(json_dict['error']['status'], 400)
@@ -1646,7 +1646,7 @@ def testDispatch(self):
16461646
self.server.client.request.headers.get=self.get_header
16471647
results = self.server.dispatch('GET',
16481648
"/rest/data/issue/1", self.empty_form)
1649-
print("9d: " + results)
1649+
print("9d: " + b2s(results))
16501650
self.assertEqual(self.server.client.response_code, 400)
16511651
json_dict = json.loads(b2s(results))
16521652
self.assertEqual(json_dict['error']['status'], 400)
@@ -1682,27 +1682,27 @@ def testDispatch(self):
16821682
self.headers={}
16831683
results = self.server.dispatch('GET',
16841684
"/rest", self.empty_form)
1685-
print("10a: " + results)
1685+
print("10a: " + b2s(results))
16861686
self.assertEqual(self.server.client.response_code, 200)
16871687
results_dict = json.loads(b2s(results))
16881688
self.assertEqual(results_dict, expected_rest)
16891689

16901690

16911691
results = self.server.dispatch('GET',
16921692
"/rest/", self.empty_form)
1693-
print("10b: " + results)
1693+
print("10b: " + b2s(results))
16941694
self.assertEqual(self.server.client.response_code, 200)
16951695
results_dict = json.loads(b2s(results))
16961696
self.assertEqual(results_dict, expected_rest)
16971697

16981698
results = self.server.dispatch('GET',
16991699
"/rest/summary", self.empty_form)
1700-
print("10c: " + results)
1700+
print("10c: " + b2s(results))
17011701
self.assertEqual(self.server.client.response_code, 200)
17021702

17031703
results = self.server.dispatch('GET',
17041704
"/rest/summary/", self.empty_form)
1705-
print("10d: " + results)
1705+
print("10d: " + b2s(results))
17061706
self.assertEqual(self.server.client.response_code, 200)
17071707

17081708
expected_data = {
@@ -1736,14 +1736,14 @@ def testDispatch(self):
17361736

17371737
results = self.server.dispatch('GET',
17381738
"/rest/data", self.empty_form)
1739-
print("10e: " + results)
1739+
print("10e: " + b2s(results))
17401740
self.assertEqual(self.server.client.response_code, 200)
17411741
results_dict = json.loads(b2s(results))
17421742
self.assertEqual(results_dict, expected_data)
17431743

17441744
results = self.server.dispatch('GET',
17451745
"/rest/data/", self.empty_form)
1746-
print("10f: " + results)
1746+
print("10f: " + b2s(results))
17471747
self.assertEqual(self.server.client.response_code, 200)
17481748
results_dict = json.loads(b2s(results))
17491749
self.assertEqual(results_dict, expected_data)

0 commit comments

Comments
 (0)