Skip to content

Commit f11e3d9

Browse files
committed
templating: rename precompileTemplates to precompile
1 parent fe4b97f commit f11e3d9

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

roundup/cgi/engine_jinja2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
[ ] figure out what to do with autoescaping - it is disabled
2626
by default in Jinja2
2727
28-
[ ] precompileTemplates is a stub
28+
[ ] precompile() is a stub
2929
3030
[ ] add {{ debug() }} dumper to inspect available variables
3131
https://github.com/mitsuhiko/jinja2/issues/174
@@ -59,7 +59,7 @@ def load(self, tplname):
5959
#src, filename = self.check(tplname)
6060
return Jinja2ProxyPageTemplate(self._env.get_template(tplname + '.html'))
6161

62-
def precompileTemplates(self):
62+
def precompile(self):
6363
pass
6464

6565
class Jinja2ProxyPageTemplate(TemplateBase):

roundup/cgi/templating.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,11 @@ def __init__(self, dir):
8484
# loaders are given the template directory as a first argument
8585
pass
8686

87-
def precompileTemplates(self):
88-
""" Go through a directory and precompile all the templates therein
87+
def precompile(self):
88+
""" This method may be called when tracker is loaded to precompile
89+
templates that support this ability.
8990
"""
91+
# [ ] move implementation out of API
9092
for filename in os.listdir(self.dir):
9193
# skip subdirs
9294
if os.path.isdir(filename):
@@ -120,6 +122,7 @@ def check(self, name):
120122

121123
def __getitem__(self, name):
122124
"""Special method to access templates by loader['name']"""
125+
# [ ] not sure if it is needed for anything except TAL templates
123126
try:
124127
return self.load(name)
125128
except NoTemplate, message:

roundup/instance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def __init__(self, tracker_home, optimize=0):
6666
self.backend = backends.get_backend(self.get_backend_name())
6767

6868
if self.optimize:
69-
self.templates.precompileTemplates()
69+
self.templates.precompile()
7070
# initialize tracker extensions
7171
for extension in self.get_extensions('extensions'):
7272
extension(self)
@@ -290,7 +290,7 @@ def open(self, tracker_home, optimize=0):
290290
tracker.optimize = optimize
291291
tracker.templates = templating.get_loader(tracker.config["TEMPLATES"])
292292
if optimize:
293-
tracker.templates.precompileTemplates()
293+
tracker.templates.precompile()
294294

295295
return tracker
296296

0 commit comments

Comments
 (0)