Skip to content

Commit ef93885

Browse files
committed
bug: fix template use of structure with untrusted data
Looks like an xSS bug with an early version of the template that was fixed in the code but never in the deployed tracker. It has been a while since this particular construct has been in the classic template which is the base for the tracker. This has been fixed on the deployed tracker as well. reported by 4bug of ChaMd5 Security Team H1 Group
1 parent 39d4c6a commit ef93885

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

website/issues/html/issue.item.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<td colspan="3" tal:condition="context/title/is_edit_ok"
4646
tal:content="structure python:context.title.field(id='title', size=60)">title</td>
4747
<td colspan="3" tal:condition="not:context/title/is_edit_ok">
48-
<span tal:content="structure context/title/plain"/>
48+
<span tal:content="context/title/plain"/>
4949
<input type="hidden" name="title" tal:attributes="value context/title">
5050
</td>
5151
</tr>

0 commit comments

Comments
 (0)