removed safeget() from the API [SF#994750]

Author: Richard Jones

CHANGES.txt

@@ -32,6 +32,7 @@ Feature:
 Fixed:
 - postgres backend open doesn't hide corruption in schema (sf bug 956375)
 - *dbm-style backends nuke() method now clear id counters
+- removed safeget() from the API (sf bug 994750)
 
 
 2004-??-?? 0.7.7

doc/upgrading.txt

@@ -16,6 +16,13 @@ steps.
 Migrating from 0.7.1 to 0.8.0
 =============================
 
+0.8.0 API changes
+-----------------
+
+Class.safeget() was removed from the API. Test your item ids before calling
+Class.get() instead.
+
+
 0.8.0 new tracker layout
 ------------------------
 

roundup/hyperdb.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: hyperdb.py,v 1.103 2004-10-08 00:56:11 richard Exp $
+# $Id: hyperdb.py,v 1.104 2004-10-08 05:44:33 richard Exp $
 
 """Hyperdatabase implementation, especially field types.
 """
@@ -554,16 +554,6 @@ def index(self, nodeid):
         '''
         raise NotImplementedError
 
-    def safeget(self, nodeid, propname, default=None):
-        """Safely get the value of a property on an existing node of this class.
-
-        Return 'default' if the node doesn't exist.
-        """
-        try:
-            return self.get(nodeid, propname)
-        except IndexError:
-            return default
-
     def export_propnames(self):
         '''List the property names for export from this Class.'''
         propnames = self.getprops().keys()

roundup/roundupdb.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: roundupdb.py,v 1.113 2004-10-08 01:58:43 richard Exp $
+# $Id: roundupdb.py,v 1.114 2004-10-08 05:44:33 richard Exp $
 
 """Extending hyperdb with types specific to issue-tracking.
 """
@@ -169,8 +169,12 @@ def nosymessage(self, nodeid, msgid, oldvalues, whichnosy='nosy',
         list. These recipients will not be included in the To: or Cc:
         address lists.
         """
-        authid = self.db.msg.safeget(msgid, 'author')
-        recipients = self.db.msg.safeget(msgid, 'recipients', [])
+        if msgid is None:
+            authid = '1'
+            recipients = []
+        else:
+            authid = self.db.msg.get(msgid, 'author')
+            recipients = self.db.msg.get(msgid, 'recipients', [])
 
         sendto = []
         bcc_sendto = []
@@ -237,8 +241,12 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
         messages = self.db.msg
         files = self.db.file
 
-        inreplyto = messages.safeget(msgid, 'inreplyto')
-        messageid = messages.safeget(msgid, 'messageid')
+        if msgid is None:
+            inreplyto = None
+            messageid = None
+        else:
+            authid = messages.get(msgid, 'inreplyto')
+            recipients = messages.get(msgid, 'messageid')
 
         # make up a messageid if there isn't one (web edit)
         if not messageid:
@@ -255,11 +263,15 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
         title = self.get(nodeid, 'title') or '%s message copy'%cn
 
         # figure author information
-        authid = messages.safeget(msgid, 'author')
-        authname = users.safeget(authid, 'realname')
+        if msgid is None:
+            authid = '1'
+            authname = 'admin'
+        else:
+            authid = messages.get(msgid, 'author')
+            authname = users.get(authid, 'realname')
         if not authname:
-            authname = users.safeget(authid, 'username', '')
-        authaddr = users.safeget(authid, 'address', '')
+            authname = users.get(authid, 'username', '')
+        authaddr = users.get(authid, 'address', '')
         if authaddr:
             authaddr = " <%s>" % straddr( ('',authaddr) )
 
@@ -281,7 +293,8 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
         m.append('')
 
         # add the content
-        m.append(messages.safeget(msgid, 'content', ''))
+        if msgid is not None:
+            m.append(messages.get(msgid, 'content', ''))
 
         # add the change note
         if note: