Skip to content

Commit e475009

Browse files
committed
Handle LoginError in rest code. Stop standard "an error occurred check
server log for details" error message from making it to the user.
1 parent a2edc3c commit e475009

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

roundup/cgi/client.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,16 @@ def handle_rest(self):
527527
self.determine_language()
528528
# Open the database as the correct user.
529529
# TODO: add everything to RestfulDispatcher
530-
self.determine_user()
530+
try:
531+
self.determine_user()
532+
except LoginError as err:
533+
self.response_code = http_.client.UNAUTHORIZED
534+
output = b"Invalid Login\n"
535+
self.setHeader("Content-Length", str(len(output)))
536+
self.setHeader("Content-Type", "text/plain")
537+
self.write(output)
538+
return
539+
531540
self.check_anonymous_access()
532541

533542
# Call rest library to handle the request

0 commit comments

Comments
 (0)