better detection of unset required props

Author: Richard Jones

roundup/cgi/client.py

@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.40 2002-09-19 02:37:41 richard Exp $
+# $Id: client.py,v 1.41 2002-09-24 02:00:09 richard Exp $
 
 __doc__ = """
 WWW request handler (also used in the stand-alone server).
@@ -1139,30 +1139,29 @@ def parsePropsFromForm(db, cl, form, nodeid=0, num_re=re.compile('^\d+$')):
             if value:
                 value = date.Date(form[key].value.strip())
             else:
-                value = None
+                continue
         elif isinstance(proptype, hyperdb.Interval):
             if value:
                 value = date.Interval(form[key].value.strip())
             else:
-                value = None
+                continue
         elif isinstance(proptype, hyperdb.Link):
             # see if it's the "no selection" choice
             if value == '-1':
-                value = None
-            else:
-                # handle key values
-                link = proptype.classname
-                if not num_re.match(value):
-                    try:
-                        value = db.classes[link].lookup(value)
-                    except KeyError:
-                        raise ValueError, _('property "%(propname)s": '
-                            '%(value)s not a %(classname)s')%{'propname':key, 
-                            'value': value, 'classname': link}
-                    except TypeError, message:
-                        raise ValueError, _('you may only enter ID values '
-                            'for property "%(propname)s": %(message)s')%{
-                            'propname':key, 'message': message}
+                continue
+            # handle key values
+            link = proptype.classname
+            if not num_re.match(value):
+                try:
+                    value = db.classes[link].lookup(value)
+                except KeyError:
+                    raise ValueError, _('property "%(propname)s": '
+                        '%(value)s not a %(classname)s')%{'propname':key, 
+                        'value': value, 'classname': link}
+                except TypeError, message:
+                    raise ValueError, _('you may only enter ID values '
+                        'for property "%(propname)s": %(message)s')%{
+                        'propname':key, 'message': message}
         elif isinstance(proptype, hyperdb.Multilink):
             if isinstance(value, type([])):
                 # it's a list of MiniFieldStorages