Skip to content

Commit e1e38c7

Browse files
committed
cleanup, comments ready for production.
1 parent 324dc3a commit e1e38c7

File tree

1 file changed

+17
-24
lines changed

1 file changed

+17
-24
lines changed

.github/workflows/ci-test.yml

Lines changed: 17 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ name: roundup-ci
44

55
on:
66
push:
7+
# skip if github.ref is 'refs/heads/maint-1.6'
8+
# aka github.ref_name of 'maint-1.6'
9+
# see https://github.com/orgs/community/discussions/26253
10+
# for mechanism to control matrix based on branch
711
branches: [ "*", '!maint-1.6' ]
812
# pull_request:
913
# branches: [ "master" ]
@@ -24,25 +28,29 @@ jobs:
2428
max-parallel: 4
2529
matrix:
2630
# Run in all these versions of Python
27-
python-version: [ "3.10", "3.11-dev" ]
28-
# python-version: [ "2.7", "3.10", "3.9", "3.8", "3.6", "3.11-dev" ]
31+
python-version: [ "2.7", "3.10", "3.9", "3.8", "3.6", "3.11-dev" ]
32+
2933
# use for multiple os or ubuntu versions
3034
#os: [ubuntu-latest, macos-latest, windows-latest]
3135
os: [ubuntu-latest, ubuntu-22.04]
36+
3237
# if the ones above fail. fail the build
3338
experimental: [false]
39+
3440
include:
3541
# example: if 3.12 fails the jobs still succeeds
3642
# - python-version: 3.12
37-
# experimental: true
38-
- python-version: 2.7
39-
os: ubuntu-22.04
40-
experimental: true
43+
# experimental: [true]
44+
# version 2,7 not available on unbuntu-22.04 github
45+
# - python-version: 2.7
46+
# os: ubuntu-22.04
47+
# experimental: true
4148
- python-version: 3.11-dev
4249
os: ubuntu-22.04
43-
experimental: true
50+
experimental: [true]
51+
4452
exclude:
45-
# disable all python versions except as explicitly included
53+
# skip all python versions on 22.04 except explicitly included
4654
- os: ubuntu-22.04
4755

4856
env:
@@ -68,21 +76,6 @@ jobs:
6876
python-version: ${{ matrix.python-version }}
6977
cache: 'pip'
7078

71-
- name: show matrix vars
72-
run: |
73-
echo 1. "${{ matrix.python-version }}"
74-
echo 2. "$PYTHON_VERSION"
75-
echo 3. "${{ matrix.os }}"
76-
env
77-
78-
- name: test if statement
79-
if: matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest'
80-
run: echo "I ran so far awaaay"
81-
82-
- name: test if statement os only
83-
if: matrix.os == 'ubuntu-latest'
84-
run: echo "I ran so far awaaay"
85-
8679
# Display the Python version being used
8780
- name: Display Python version
8881
run: python -c "import sys; print(sys.version)"
@@ -211,7 +204,7 @@ jobs:
211204
python ./setup.py build_doc
212205
213206
#- name: test docker build current version ubuntu-latest
214-
# if: {{ matrix.python_version == "3.10" && matrix.os == "ubuntu-latest" }}
207+
# if: matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest'
215208
# run: |
216209
# docker build -t roundup-app-dev -f scripts/Docker/Dockerfile .
217210
# mkdir tracker; chmod 777 tracker

0 commit comments

Comments
 (0)