Fix Issue2551030: Roundup fails to start if pytz to access Olson

timezone database not installed

Create property TimezoneOption.defaulttz properly and use it to
initialize the entry in the SETTINGS data structure for the timezone
option.

Author: rouilj

CHANGES.txt

@@ -12,7 +12,7 @@ v2.7.2 is required to run newer releases of Roundup.  From v?.?
 onwards Python 3.4 and later are also supported.
 
 
-2018-??-?? ?.?.0
+2019-??-?? ?.?.0
 
 Features:
 
@@ -143,6 +143,8 @@ Fixed:
 - issue2551009: Flint not supported error during reindex. Upgrading
   doc updates to discuss this when reindexing. (Reported by Gabi,
   Change by John Rouillard)
+- issue2551030: Roundup fails to start if pytz to access Olson
+  timezone database not installed. (John Rouillard)
 
 2018-07-13 1.6.0
 

roundup/configuration.py

@@ -544,6 +544,14 @@ class TimezoneOption(Option):
         "If pytz is not installed, value must be integer number\n" \
         "giving local timezone offset from UTC in hours."
 
+    # fix issue2551030, default value for timezone
+    # Must be 0 if no pytz can be UTC if pytz.
+    try:
+        import pytz
+        defaulttz = "UTC"
+    except ImportError:
+        defaulttz = "0"
+
     def str2value(self, value):
         try:
             roundup.date.get_timezone(value)
@@ -552,6 +560,7 @@ def str2value(self, value):
                     "Timezone name or numeric hour offset required")
         return value
 
+    
 class RegExpOption(Option):
 
     """Regular Expression option (value is Regular Expression Object)"""
@@ -658,7 +667,8 @@ def str2value(self, value):
             "If you wish to make them xhtml, then you'll need to change this\n"
             "var to 'xhtml' too so all auto-generated HTML is compliant.\n"
             "Allowed values: html4, xhtml"),
-        (TimezoneOption, "timezone", "UTC", "Default timezone offset,"
+        (TimezoneOption, "timezone", TimezoneOption.defaulttz,
+            "Default timezone offset,"
             " applied when user's timezone is not set.",
             ["DEFAULT_TIMEZONE"]),
         (BooleanOption, "instant_registration", "no",