Skip to content

Commit e18308e

Browse files
author
Roche Compaan
committed
Properties in change note are now sorted
1 parent 4b2bbd2 commit e18308e

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Feature:
66
. much nicer history display (actualy real handling of property types etc)
77
. journal entries for link and mutlilink properties can be switched on or
88
off
9+
. properties in change note are now sorted
910

1011
Fixed:
1112
. handle attachments with no name (eg tnef)

roundup/roundupdb.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
# $Id: roundupdb.py,v 1.41 2002-01-15 00:12:40 richard Exp $
18+
# $Id: roundupdb.py,v 1.42 2002-01-21 09:55:14 rochecompaan Exp $
1919

2020
__doc__ = """
2121
Extending hyperdb with types specific to issue-tracking.
@@ -461,13 +461,13 @@ def generateCreateNote(self, nodeid):
461461

462462
# list the values
463463
m = []
464-
l = props.items()
465-
l.sort()
464+
l = props.items()
465+
l.sort()
466466
for propname, prop in l:
467467
value = cl.get(nodeid, propname, None)
468-
# skip boring entries
469-
if not value:
470-
continue
468+
# skip boring entries
469+
if not value:
470+
continue
471471
if isinstance(prop, hyperdb.Link):
472472
link = self.db.classes[prop.classname]
473473
if value:
@@ -514,7 +514,9 @@ def generateChangeNote(self, nodeid, oldvalues):
514514

515515
# list the changes
516516
m = []
517-
for propname, oldvalue in changed.items():
517+
l = changed.items()
518+
l.sort()
519+
for propname, oldvalue in l:
518520
prop = cl.properties[propname]
519521
value = cl.get(nodeid, propname, None)
520522
if isinstance(prop, hyperdb.Link):
@@ -566,6 +568,9 @@ def generateChangeNote(self, nodeid, oldvalues):
566568

567569
#
568570
# $Log: not supported by cvs2svn $
571+
# Revision 1.41 2002/01/15 00:12:40 richard
572+
# #503340 ] creating issue with [asignedto=p.ohly]
573+
#
569574
# Revision 1.40 2002/01/14 22:21:38 richard
570575
# #503353 ] setting properties in initial email
571576
#

0 commit comments

Comments
 (0)