Skip to content

Commit e03f32f

Browse files
author
Richard Jones
committed
[SF#503793] changing assignedto resets nosy list
1 parent 5455588 commit e03f32f

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ Fixed:
2727
. #502956 ] filtering by multilink not supported
2828
. #503340 ] creating issue with [asignedto=p.ohly]
2929
. #502949 ] index view for non-issues and redisplay
30+
. #503793 ] changing assignedto resets nosy list
3031

3132

3233
2002-01-08 - 0.4.0b1

roundup/cgi_client.py

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
# $Id: cgi_client.py,v 1.98 2002-01-14 02:20:14 richard Exp $
18+
# $Id: cgi_client.py,v 1.99 2002-01-16 03:02:42 richard Exp $
1919

2020
__doc__ = """
2121
WWW request handler (also used in the stand-alone server).
@@ -343,8 +343,16 @@ def _add_assignedto_to_nosy(self, props):
343343
return
344344
assignedto_id = props['assignedto']
345345
if not props.has_key('nosy'):
346-
props['nosy'] = [assignedto_id]
347-
elif assignedto_id not in props['nosy']:
346+
# load current nosy
347+
if self.nodeid:
348+
cl = self.db.classes[self.classname]
349+
l = cl.get(self.nodeid, 'nosy')
350+
if assignedto_id in l:
351+
return
352+
props['nosy'] = l
353+
else:
354+
props['nosy'] = []
355+
if assignedto_id not in props['nosy']:
348356
props['nosy'].append(assignedto_id)
349357

350358
def _changenode(self, props):
@@ -1165,6 +1173,15 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
11651173

11661174
#
11671175
# $Log: not supported by cvs2svn $
1176+
# Revision 1.98 2002/01/14 02:20:14 richard
1177+
# . changed all config accesses so they access either the instance or the
1178+
# config attriubute on the db. This means that all config is obtained from
1179+
# instance_config instead of the mish-mash of classes. This will make
1180+
# switching to a ConfigParser setup easier too, I hope.
1181+
#
1182+
# At a minimum, this makes migration a _little_ easier (a lot easier in the
1183+
# 0.5.0 switch, I hope!)
1184+
#
11681185
# Revision 1.97 2002/01/11 23:22:29 richard
11691186
# . #502437 ] rogue reactor and unittest
11701187
# in short, the nosy reactor was modifying the nosy list. That code had

0 commit comments

Comments
 (0)