Bug fixes:

 . Fixed bug in re generation in the filter (I hadn't finished the code ;)
 . Added TODO as a priority (between bug and usability)
 . Fixed handling of None String property in grouped list headings

Author: Richard Jones

CHANGES

@@ -24,7 +24,8 @@
    properties, etc.
  . Set the default index to sort on activity
 
-2001-07-XX - 0.1.3
+
+2001-07-19 - 0.1.3
  . Reldate now takes an argument "pretty" - when true, it pretty-prints the
    interval generated up to 5 days, then pretty-prints the date of last
    activity. The issue index and item now use the pretty format.
@@ -43,3 +44,9 @@
     te*xt  - search for text matching "te"<any characters>"xt"
     te?xt  - search for text matching "te"<any one character>"xt"
  . Added more fields to the issue.filter and issue.index templates
+
+
+2001-07-19 - 0.1.4
+ . Fixed bug in re generation in the filter (I hadn't finished the code ;)
+ . Added TODO as a priority (between bug and usability)
+ . Fixed handling of None String property in grouped list headings

Makefile

@@ -11,8 +11,8 @@ release:
 	mkdir /tmp/${PACKAGE}
 	cp -r ${FILES} /tmp/${PACKAGE}
 	cp dummy_config.py /tmp/${PACKAGE}
-	(cd /tmp; tar zcf ${PACKAGE}.tgz ${PACKAGE})
-	mv /tmp/${PACKAGE}.tgz .
+	(cd /tmp; tar zcf ${PACKAGE}.tar.gz ${PACKAGE})
+	mv /tmp/${PACKAGE}.tar.gz .
 
 clean:
-	rm -f *.pyc *.tgz
+	rm -f *.pyc *.tar.gz

config.py

@@ -8,7 +8,7 @@
 ADMIN_EMAIL = "[email protected]"
 
 # The SMTP mail host that roundup will use to send mail
-MAILHOST = 'goanna.adroit.net'
+MAILHOST = 'dirk'
 
 # Somewhere for roundup to log stuff internally sent to stdout or stderr
 LOG = '/home/httpd/html/roundup/roundup.log'

hyperdb.py

@@ -648,8 +648,9 @@ def filter(self, filterspec, sort, group, num_re = re.compile('^\d+$')):
                 v = v[0]
                 if '*' in v or '?' in v:
                     # simple glob searching
-                    v = v.replace(v, '?', '.')
-                    v = v.replace(v, '*', '.*?')
+                    v = v.replace('?', '.')
+                    v = v.replace('*', '.*?')
+                    v = re.compile(v)
                     l.append((2, k, v))
                 elif v[0] == '^':
                     # start-anchored
@@ -690,7 +691,7 @@ def filter(self, filterspec, sort, group, num_re = re.compile('^\d+$')):
                     else:
                         continue
                     break
-                elif t == 2 and not v.match(node[k]):
+                elif t == 2 and not v.search(node[k]):
                     # RE search
                     break
                 elif t == 3 and node[k][:len(v)] != v:
@@ -748,10 +749,10 @@ def sortfun(a, b, sort=sort, group=group, properties=self.getprops(),
 
                     # String and Date values are sorted in the natural way
                     if propclass.isStringType:
-                        # make sure that case doesn't get involved
-                        if av[0] in string.uppercase:
+                        # clean up the strings
+                        if av and av[0] in string.uppercase:
                             av = an[prop] = av.lower()
-                        if bv[0] in string.uppercase:
+                        if bv and bv[0] in string.uppercase:
                             bv = bn[prop] = bv.lower()
                     if propclass.isStringType or propclass.isDateType:
                         if dir == '+':

roundup_cgi.py

@@ -212,11 +212,12 @@ def showitem(self, message=None):
                         props[key] = value
                 cl.set(self.nodeid, **props)
 
-                # if this item has messages, 
+                # if this item has messages, generate an edit message
+                # TODO: don't send the edit message to the person who
+                # performed the edit
                 if (cl.getprops().has_key('messages') and
                         cl.getprops()['messages'].isMultilinkType and
                         cl.getprops()['messages'].classname == 'msg'):
-                    # generate an edit message - nosyreactor will send it
                     nid = self.nodeid
                     m = []
                     for name, prop in cl.getprops().items():

roundupdb.py

@@ -329,8 +329,9 @@ def initDB(storagelocator, password):
     pri = db.getclass('priority')
     pri.create(name="fatal-bug", order="1")
     pri.create(name="bug", order="2")
-    pri.create(name="usability", order="3")
-    pri.create(name="feature", order="4")
+    pri.create(name="todo", order="3")
+    pri.create(name="usability", order="4")
+    pri.create(name="feature", order="5")
 
     stat = db.getclass('status')
     stat.create(name="unread", order="1")

template.py

@@ -506,7 +506,10 @@ def index(fp, db, classname, filterspec={}, filter=[], columns=[], sort=[],
                         for value in cl.get(nodeid, name):
                             l.append(group_cl.get(value, key))
                     else:
-                        l.append(cl.get(nodeid, name))
+                        value = cl.get(nodeid, name)
+                        if value is None:
+                            value = '[empty %s]'%name
+                        l.append(value)
                 w('<tr class="list-header">'
                   '<td align=left colspan=%s><strong>%s</strong></td></tr>'%(
                     len(columns), ', '.join(l)))