Skip to content

Commit dcef024

Browse files
author
Richard Jones
committed
fix potential XSS hole
1 parent d4aa50e commit dcef024

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

roundup/cgi/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1069,9 +1069,9 @@ def renderContext(self):
10691069
result = result.replace('</body>', s)
10701070
return result
10711071
except templating.NoTemplate, message:
1072-
return '<strong>%s</strong>'%message
1072+
return '<strong>%s</strong>'%cgi.escape(str(message))
10731073
except templating.Unauthorised, message:
1074-
raise Unauthorised(str(message))
1074+
raise Unauthorised(cgi.escape(str(message)))
10751075
except:
10761076
# everything else
10771077
if self.instance.config.WEB_DEBUG:

roundup/cgi/templating.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ def find_template(dir, name, view):
115115
if os.path.exists(src):
116116
return (src, generic)
117117

118-
raise NoTemplate, 'No template file exists for templating "%s" '\
118+
raise NoTemplate('No template file exists for templating "%s" '
119119
'with template "%s" (neither "%s" nor "%s")'%(name, view,
120-
filename, generic)
120+
filename, generic))
121121

122122
class Templates:
123123
templates = {}

0 commit comments

Comments
 (0)