role names made case insensitive

Author: Andrey Lebedev

CHANGES.txt

@@ -43,6 +43,7 @@ Feature:
 - relaxed CVS importing (sf feature 693277)
 - added support for searching on ranges of dates (see doc/user_guide.txt in
   chapter "Searching Page" for details)
+- role names made case insensitive
 
 
 Fixed:

roundup/security.py

@@ -27,7 +27,7 @@ class Role:
         - permissions
     '''
     def __init__(self, name='', description='', permissions=None):
-        self.name = name
+        self.name = name.lower()
         self.description = description
         if permissions is None:
             permissions = []
@@ -98,7 +98,7 @@ def hasPermission(self, permission, userid, classname=None):
         roles = self.db.user.get(userid, 'roles')
         if roles is None:
             return 0
-        for rolename in roles.split(','):
+        for rolename in [x.lower() for x in roles.split(',')]:
             if not rolename or not self.role.has_key(rolename):
                 continue
             # for each of the user's Roles, check the permissions
@@ -155,7 +155,7 @@ def addPermissionToRole(self, rolename, permission):
 
             'rolename' is the name of the role to add the permission to.
         '''
-        role = self.role[rolename]
+        role = self.role[rolename.lower()]
         role.permissions.append(permission)
 
 # vim: set filetype=python ts=4 sw=4 et si

test/test_mailgw.py

@@ -8,7 +8,7 @@
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# $Id: test_mailgw.py,v 1.40 2003-02-28 03:33:25 richard Exp $
+# $Id: test_mailgw.py,v 1.41 2003-03-13 09:27:24 kedder Exp $
 
 import unittest, cStringIO, tempfile, os, shutil, errno, imp, sys, difflib
 
@@ -644,7 +644,7 @@ def testNosyRemove(self):
     def testNewUserAuthor(self):
         # first without the permission
         # heh... just ignore the API for a second ;)
-        self.db.security.role['Anonymous'].permissions=[]
+        self.db.security.role['anonymous'].permissions=[]
         anonid = self.db.user.lookup('anonymous')
         self.db.user.set(anonid, roles='Anonymous')
 
@@ -670,7 +670,7 @@ def testNewUserAuthor(self):
 
         # now with the permission
         p = self.db.security.getPermission('Email Registration')
-        self.db.security.role['Anonymous'].permissions=[p]
+        self.db.security.role['anonymous'].permissions=[p]
         handler = self.instance.MailGW(self.instance, self.db)
         handler.trapExceptions = 0
         message = cStringIO.StringIO(s)