issue2551181 - allow issueXXX#fragment to generate a link with fragment

There is another ticket to add id's to elements displaying messages in
issue.item.html. This change allows a fast way to link to such an
element in a long issue with many messages once that other issue is
committed and merged into a tracker template.

Author: rouilj

CHANGES.txt

@@ -96,6 +96,11 @@ Features:
   Access-Control-Allow-Headers headers. (John Rouillard)
 - issue2550991 - define default cache control settings for javascript
   and css assets. (John Rouillard)
+- issue2551181 - fragments can be appended to designators. So
+  issue23#msg24 could jump to the element with id msg24 in issue 23.
+  Before this patch you would have two links issue23 and msg24
+  separated by # (John Rouillard).
+
 
 2021-07-13 2.1.0
 

roundup/cgi/templating.py

@@ -1612,7 +1612,7 @@ class StringHTMLProperty(HTMLProperty):
          (/[\w\-$.+!*(),;:@&=?/~\\#%]*)?   # path etc.
         )|
         (?P<email>[-+=%/\w\.]+@[\w\.\-]+)|
-        (?P<item>(?P<class>[A-Za-z_]+)(\s*)(?P<id>\d+))
+        (?P<item>(?P<class>[A-Za-z_]+)(\s*)(?P<id>\d+)(?P<fragment>\#[^][\#%^{}"<>\s]+)?)
     )''', re.X | re.I)
     protocol_re = re.compile('^(ht|f)tp(s?)://', re.I)
 
@@ -1630,7 +1630,7 @@ def _hyper_repl(self, match):
             return self._hyper_repl_email(match, '<a href="mailto:%s">%s</a>')
         elif len(match.group('id')) < 10:
             return self._hyper_repl_item(match,
-                '<a href="%(cls)s%(id)s">%(item)s</a>')
+                '<a href="%(cls)s%(id)s%(fragment)s">%(item)s</a>')
         else:
             # just return the matched text
             return match.group(0)
@@ -1664,6 +1664,9 @@ def _hyper_repl_item(self, match, replacement):
         item = match.group('item')
         cls = match.group('class').lower()
         id = match.group('id')
+        fragment = match.group('fragment')
+        if fragment is None:
+            fragment=""
         try:
             # make sure cls is a valid tracker classname
             cl = self._db.getclass(cls)

test/test_templating.py

@@ -450,6 +450,9 @@ def test_url_replace(self):
         p = StringHTMLProperty(self.client, 'test', '1', None, 'test', '')
         def t(s): return p.hyper_re.sub(p._hyper_repl, s)
         ae = self.assertEqual
+        ae(t('issue5#msg10'), '<a href="issue5#msg10">issue5#msg10</a>')
+        ae(t('issue5'), '<a href="issue5">issue5</a>')
+        ae(t('issue2255'), 'issue2255')
         ae(t('foo https://example.com/demo/issue8#24MRV9BZYx:V:1B~sssssssssssssss~4~4 bar'),
            'foo <a href="https://example.com/demo/issue8#24MRV9BZYx:V:1B~sssssssssssssss~4~4" rel="nofollow noopener">'
            'https://example.com/demo/issue8#24MRV9BZYx:V:1B~sssssssssssssss~4~4</a> bar')