Move db.commit() call from handle_xmlrpc() to individual methods...

...so actions can control it themselves.

Author: stefanseefeld

roundup/cgi/client.py

@@ -387,7 +387,6 @@ def handle_xmlrpc(self):
                                            self.translator,
                                            allow_none=True)
         output = handler.dispatch(input)
-        self.db.commit()
 
         self.setHeader("Content-Type", "text/xml")
         self.setHeader("Content-Length", str(len(output)))

roundup/xmlrpc.py

@@ -120,6 +120,7 @@ def create(self, classname, *args):
         # do the actual create
         try:
             result = cl.create(**props)
+            self.db.commit()
         except (TypeError, IndexError, ValueError), message:
             raise UsageError, message
         return result
@@ -135,9 +136,11 @@ def set(self, designator, *args):
                 raise Unauthorised('Permission to edit %s of %s denied'%
                                    (p, designator))
         try:
-            return cl.set(itemid, **props)
+            result = cl.set(itemid, **props)
+            self.db.commit()
         except (TypeError, IndexError, ValueError), message:
             raise UsageError, message
+        return result
 
 
     builtin_actions = {'retire': actions.Retire}